Skip to content

Conversation

@davidsekar
Copy link
Contributor

  • npm run test -> runs tests using chrome browser

  • npm run test:ci -> runs tests using phantomjs ( suitable for CI )

  • npm run test:watch, npm run test:ci:watch -> watch mode

  • Speed up build/rebuilding unit testcases (using DLLBundlePlugin - vendor.js) .

  • removed deprecated tslint rules and updated the modified ones.

@MarkPieszak
Copy link
Member

There are some issues with DLLBundle and AoT typically, were you able to produce prod bundles even with that in Vendor ?

@MarkPieszak
Copy link
Member

This looks fantastic though otherwise !

@davidsekar
Copy link
Contributor Author

This PR uses DLL for speeding up testcase rebuild time & DLL plugin did work fine as i was building it in development mode(not prod mode).

I had issue with AoT and lazy loading in SSR for the prod builds, but that doesn't affect this PR.

@davidsekar
Copy link
Contributor Author

davidsekar commented Sep 9, 2017

The creator of DLL plugin has commented that the DLLPlugin is not for production builds as it prevent few benefits the webpack loaders can do.
shlomiassaf/webpack-dll-bundles-plugin#21 (comment)

AOT + DLLPlugin + Lazy - seems not working for months
So not sure why dotnet SPA Angular template has this DLL plugin enabled for production build.

I will remove the DLL plugin and test my prod builds.

@MarkPieszak
Copy link
Member

Yeah there are some issues that the team is working on in regards to all of that, it's definitely complicated ! Let me know when I can merge this though!

@davidsekar
Copy link
Contributor Author

@MarkPieszak You can merge this PR as the unit tests are not executed against AoT bundle. So it works fine with current DLLPlugin setup.

@MarkPieszak MarkPieszak merged commit f489940 into TrilonIO:master Sep 10, 2017
@jrmcdona
Copy link
Contributor

@davidsekar do you know why the Coverage report doesn't show errors? Seems to just focus on coverage. What do you use for outputting errors on CI build?

@davidsekar
Copy link
Contributor Author

davidsekar commented Sep 19, 2017

@jrmcdona
Try npm run test:ci, which uses phantomjs to run your test cases and then generates code coverage.

If you want to debug test cases, then run with chrome npm run test which also generates coverage.

I have not tested npm run coverage, which was earlier used with Zest. Will try to check and see how that one works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants