-
Notifications
You must be signed in to change notification settings - Fork 429
(Unit Testing) Run unit testcases using PhantomJS in Continuous Integration environments #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull latest changes from base fork
Merge latest changes from master repo
Pull changes from Base repo for preboot
…ed tslint rules and amended existing rules.
|
There are some issues with DLLBundle and AoT typically, were you able to produce prod bundles even with that in Vendor ? |
|
This looks fantastic though otherwise ! |
|
This PR uses DLL for speeding up testcase rebuild time & DLL plugin did work fine as i was building it in development mode(not prod mode). I had issue with AoT and lazy loading in SSR for the prod builds, but that doesn't affect this PR. |
|
The creator of DLL plugin has commented that the DLLPlugin is not for production builds as it prevent few benefits the webpack loaders can do. AOT + DLLPlugin + Lazy - seems not working for months I will remove the DLL plugin and test my prod builds. |
|
Yeah there are some issues that the team is working on in regards to all of that, it's definitely complicated ! Let me know when I can merge this though! |
|
@MarkPieszak You can merge this PR as the unit tests are not executed against AoT bundle. So it works fine with current DLLPlugin setup. |
|
@davidsekar do you know why the Coverage report doesn't show errors? Seems to just focus on coverage. What do you use for outputting errors on CI build? |
|
@jrmcdona If you want to debug test cases, then run with chrome npm run test which also generates coverage. I have not tested npm run coverage, which was earlier used with Zest. Will try to check and see how that one works |
npm run test -> runs tests using chrome browser
npm run test:ci -> runs tests using phantomjs ( suitable for CI )
npm run test:watch, npm run test:ci:watch -> watch mode
Speed up build/rebuilding unit testcases (using DLLBundlePlugin - vendor.js) .
removed deprecated tslint rules and updated the modified ones.