[Isle of Conquest] Catapult Bug

[Tangol]

The Launch spell (http://www.wowhead.com/spell=66251) of IoC Catapults (http://www.wowhead.com/npc=34793) doesn't work.
The base spell (www.wowhead.com/spell=66218) seems to work, as you see the animation and you get thrown to the designated location, but at the moment you land, you instantly get pulled back to the catapult and you're unable to move. Only dismounting it solves the issue.

Rev: fccdba3

[D4R4]

Disable Effect1 (or was it Effect2?) of the spell using SpellMgr and it will work as intended ([EFFECT1].Effect=0)

[Trisjdc]

The whole spell isn't working properly, even aside that. The gun seat is supposed to be launched, not the driver seat as it currently happens.

[Golrag]

Try this

diff --git a/src/server/scripts/Northrend/isle_of_conquest.cpp b/src/server/scripts/Northrend/isle_of_conquest.cpp
index 1476357..0f10ffa 100644
--- a/src/server/scripts/Northrend/isle_of_conquest.cpp
+++ b/src/server/scripts/Northrend/isle_of_conquest.cpp
@@ -145,6 +145,31 @@ enum Launch
     SPELL_LAUNCH_NO_FALLING_DAMAGE  = 66251
 };

+class StartLaunchEvent : public BasicEvent
+{
+    public:
+        StartLaunchEvent(WorldLocation const* const position, Player* player)
+            : _position(position),  _player(player)
+        {
+        }
+
+        bool Execute(uint64 /*time*/, uint32 /*diff*/)
+        {
+            _player->AddAura(SPELL_LAUNCH_NO_FALLING_DAMAGE, _player); // prevents falling damage
+            float speedZ = 10.0f;
+            float dist = _position->GetExactDist2d(_player->GetPositionX(), _player->GetPositionY());
+            float speedXY = dist;
+
+            _player->ExitVehicle();
+            _player->GetMotionMaster()->MoveJump(_position->GetPositionX(), _position->GetPositionY(), _position->GetPositionZ(), speedXY, speedZ);
+            return true;
+        }
+
+    private:
+        WorldLocation const* const _position;
+        Player* _player;
+};
+
 class spell_ioc_launch : public SpellScriptLoader
 {
     public:
@@ -154,34 +179,17 @@ class spell_ioc_launch : public SpellScriptLoader
         {
             PrepareSpellScript(spell_ioc_launch_SpellScript);

-            void HandleScript(SpellEffIndex /*effIndex*/)
-            {
-                if (Player* player = GetHitPlayer())
-                    player->AddAura(SPELL_LAUNCH_NO_FALLING_DAMAGE, player); // prevents falling damage
-            }
-
             void Launch()
             {
                 WorldLocation const* const position = GetExplTargetDest();
+                if (!GetCaster()->ToCreature())
+                    return;

-                if (Player* player = GetHitPlayer())
-                {
-                    player->ExitVehicle();
-
-                    // A better research is needed
-                    // There is no spell for this, the following calculation was based on void Spell::CalculateJumpSpeeds
-
-                    float speedZ = 10.0f;
-                    float dist = position->GetExactDist2d(player->GetPositionX(), player->GetPositionY());
-                    float speedXY = dist;
-
-                    player->GetMotionMaster()->MoveJump(position->GetPositionX(), position->GetPositionY(), position->GetPositionZ(), speedXY, speedZ);
-                }
+                GetCaster()->ToCreature()->m_Events.AddEvent(new StartLaunchEvent(position, GetHitPlayer()), GetCaster()->ToCreature()->m_Events.CalculateTime(2500));
             }

             void Register() override
             {
-                OnEffectHitTarget += SpellEffectFn(spell_ioc_launch_SpellScript::HandleScript, EFFECT_1, SPELL_EFFECT_FORCE_CAST);
                 AfterHit += SpellHitFn(spell_ioc_launch_SpellScript::Launch);
             }
         };

[H4D3S]

👍