Build: Enable and require c++17 #23868
Conversation
|
Conflicting files |
# Conflicts: # dep/argon2/CMakeLists.txt
|
Cleaned up the PR with only the changes required for C++17 after some CMake bits have been merged to 3.3.5 already |
|
anyone against merging this PR ? |
|
Maybe replace the label [Feedback-FixOutdatedMissingWIP] with [Feedback-PatchFix] before merging, just to signify its current state. Otherwise, this PR has been available for quite a while, so if anybody with an opinion has not reviewed or tested this yet, they are unlikely to respond before this gets merged anyway. |
Aokromes
added
Feedback-PatchFix
help wanted
and removed
Feedback-FixOutdatedMissingWIP
labels
|
This PR is planned to be merged this weekend. Speak before that if you don't want that (and maybe provide some valid reasons about it) |
|
so compiling with Microsoft Visual Studio/2017/Community/VC will still all wotk smooth? |
https://community.trinitycore.org/topic/14655-gcc-63-visual-studio-2017-156-end-of-life/ |
|
aok wrote: Since we are targeting C++17 compilers, GCC 6.3, clang 4 and Visual Studio 2017 under version 15.7 will become unsupported after summer perfect thanks! |
|
@Rushor this PR raises VC++ required version to 19.16 which means VS 2017 15.9+ https://docs.microsoft.com/en-us/visualstudio/releasenotes/vs2017-relnotes#-visual-studio-2017-version-1590 as previous VS 2017 versions had C++17 bugs. I would suggest to update to latest VS 2017 or to latest VS 2019 to get latest fixes from the VS team. |
|
alright - thank you very much! |
|
Nitpick: also set Zc:__cplusplus on Windows to get proper value for the language version (it previously always reported as c++98) (Yes i know _MSVC_LANG is a thing but that's not standard) |
|
I would prefer to change that flag in another PR, maybe removing _MSVC_VER checks, and testing it. |
|
Aight go (might want to toggle __cplusplus on our code only since deps might rely on C++98 value checks) |
This reverts commit 726d5e9.
ghost
mentioned this pull request
This reverts commit 726d5e9.
* Build: Enable and require c++17 * Build: Raise Visual Studio version from 2017 15.2 to 2017 15.9 * Build: Raise GCC version from 6.3.0 to 7.1.0 * Reduce branch differences * Fix build after latest merge * Cleanup after latest merge (cherry picked from commit 726d5e9)
* Build: Enable and require c++17 * Build: Raise Visual Studio version from 2017 15.2 to 2017 15.9 * Build: Raise GCC version from 6.3.0 to 7.1.0 * Reduce branch differences * Fix build after latest merge * Cleanup after latest merge (cherry picked from commit 726d5e9)
5 participants
Changes proposed:
Target branch(es): 3.3.5/master
Issues addressed: None
Tests performed: (Does it build, tested in-game, etc.)
Known issues and TODO list: (add/remove lines as needed)