Skip to content

feat(trogonstack-ask): add trogonstack-ask plugin#22

Merged
yordis merged 1 commit intomainfrom
add-ask-question
Mar 18, 2026
Merged

feat(trogonstack-ask): add trogonstack-ask plugin#22
yordis merged 1 commit intomainfrom
add-ask-question

Conversation

@yordis
Copy link
Copy Markdown
Member

@yordis yordis commented Mar 18, 2026

Summary

  • Adds trogonstack-ask plugin with ask-question skill
  • Structured Q&A skill that asks one question at a time with question, intention, and assumptions
  • Optionally saves the Q&A session to a file as the conversation progresses

Test plan

  • Install plugin and invoke /trogonstack-ask:ask-question
  • Verify questions follow the structured format
  • Verify file save prompt appears before the first question

@cursor
Copy link
Copy Markdown

cursor bot commented Mar 18, 2026

PR Summary

Low Risk
Low risk: adds a new plugin and release metadata only, with no runtime logic changes beyond a new Claude skill definition.

Overview
Adds a new trogonstack-ask Claude plugin that provides an ask-question skill for conducting structured, one-question-at-a-time requirement gathering, with optional Q&A session logging to a .qa.md file.

Registers trogonstack-ask in the plugin marketplace and wires it into release-please (release-please-config.json and manifest) for independent versioning starting at 0.0.0.

Written by Cursor Bugbot for commit eb8bb44. This will update automatically on new commits. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 18, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4445767d-46a6-4e64-8ea0-74a4fa1e6801

📥 Commits

Reviewing files that changed from the base of the PR and between 1b96105 and eb8bb44.

📒 Files selected for processing (5)
  • .claude-plugin/marketplace.json
  • .github/release-please-config.json
  • .github/release-please-manifest.json
  • plugins/trogonstack-ask/.claude-plugin/plugin.json
  • plugins/trogonstack-ask/skills/ask-question/SKILL.md

Walkthrough

Adds a new trogonstack-ask plugin: plugin manifest, a skill doc describing a structured one-question-at-a-time "ask-question" workflow, and registers the plugin in marketplace and release-please metadata.

Changes

Cohort / File(s) Summary
Plugin manifest & skill
plugins/trogonstack-ask/.claude-plugin/plugin.json, plugins/trogonstack-ask/skills/ask-question/SKILL.md
Adds a new Claude plugin manifest (name, description, version, author) and a skill document defining the "ask-question" interaction pattern, question format, and optional session save/append behavior.
Marketplace entry
.claude-plugin/marketplace.json
Inserts a trogonstack-ask entry into the marketplace array with name, description, source, and category.
Release tooling metadata
.github/release-please-config.json, .github/release-please-manifest.json
Registers plugins/trogonstack-ask in release-please packages and manifest with initial version 0.0.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐇 I hop through queries, one by one,
I name intent and note what's done,
I ask, I wait, then jot the say,
A little log to keep the way,
Soft paws, sharp questions — here we run.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description is directly related to the changeset, detailing the plugin addition, the ask-question skill, its structured Q&A format, and optional file saving functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'feat(trogonstack-ask): add trogonstack-ask plugin' directly and clearly summarizes the main change—adding a new plugin named trogonstack-ask with its associated skill and configuration files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Important

Merge conflicts detected (Beta)

  • Resolve merge conflict in branch add-ask-question
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-ask-question
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@plugins/trogonstack-ask/.claude-plugin/plugin.json`:
- Around line 2-4: Add the new plugin directory "plugins/trogonstack-ask" to the
release-please configuration by updating the packages array in the repository's
release-please config (the JSON object containing the "packages" key) to include
an entry for the plugin; ensure the entry references the package path
"plugins/trogonstack-ask" (and set any required metadata like packageName or
releaseType consistent with other entries) so automated release/versioning will
include this new plugin.

In `@plugins/trogonstack-ask/skills/ask-question/SKILL.md`:
- Line 20: Update the Q&A save flow described in SKILL.md so that before
creating any file (the step that currently reads "Before asking the first
question, ask the user if they want the Q&A session saved to a file") the skill
explicitly: 1) prompts the user for and confirms the desired filename/path
(showing a safe default), 2) validates the filename (reject absolute paths and
path traversal like ../), 3) asks and records explicit consent for persistence
and for overwrite if the file exists, 4) offers a redaction/minimization toggle
to remove or mask sensitive fields before writing, and 5) logs the user’s choice
and only create/append the file after these checks; implement these checks
around the code that creates/appends the file so consent, validation, overwrite
handling, and redaction are enforced every session.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f942f8fd-a06e-4297-9a21-4023d4847094

📥 Commits

Reviewing files that changed from the base of the PR and between 37568f1 and 3865313.

📒 Files selected for processing (2)
  • plugins/trogonstack-ask/.claude-plugin/plugin.json
  • plugins/trogonstack-ask/skills/ask-question/SKILL.md

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
plugins/trogonstack-ask/skills/ask-question/SKILL.md (1)

22-22: ⚠️ Potential issue | 🟠 Major

Add explicit persistence safety checks before writing to disk.

Line 22 still allows immediate file creation/append without explicit filename/path confirmation, overwrite handling, or data-minimization/redaction choice. This is a privacy/compliance risk.

🔧 Suggested wording update
-Before asking the first question, ask the user if they want the Q&A session saved to a file. If they agree, create the file immediately and append each question and answer to it as the conversation progresses.
+Before asking the first question, ask the user if they want the Q&A session saved to a file. If yes, ask for and confirm a safe filename/path, confirm whether to create or append if the file exists, and ask whether sensitive content should be minimized/redacted before writing. Only after explicit consent, create/append the file as the conversation progresses.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@plugins/trogonstack-ask/skills/ask-question/SKILL.md` at line 22, The current
behavior described by "create the file immediately and append each question and
answer to it as the conversation progresses" lacks safety checks; update the
flow in SKILL.md to first prompt the user for explicit filename/path
confirmation (show a safe default and validate it), check if the file already
exists and ask whether to overwrite, append, or cancel, present an option to
enable data minimization/redaction (and describe what will be redacted) and
record the user's consent, and only after those confirmations create/open the
file and append entries while logging the chosen persistence mode.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@plugins/trogonstack-ask/skills/ask-question/SKILL.md`:
- Around line 1-8: The marketplace metadata is missing an entry for the new
skill; add a JSON object for the trogonstack-ask plugin (id: "trogonstack-ask",
name: "ask-question") into the marketplace.json plugins array so it is
discoverable, including a brief description, version, icon or icon_url,
categories/tags and a pointer to the skill documentation (SKILL.md) and ensure
the file remains valid JSON (no trailing commas) and the entry keys match
existing plugin entries' schema.

---

Duplicate comments:
In `@plugins/trogonstack-ask/skills/ask-question/SKILL.md`:
- Line 22: The current behavior described by "create the file immediately and
append each question and answer to it as the conversation progresses" lacks
safety checks; update the flow in SKILL.md to first prompt the user for explicit
filename/path confirmation (show a safe default and validate it), check if the
file already exists and ask whether to overwrite, append, or cancel, present an
option to enable data minimization/redaction (and describe what will be
redacted) and record the user's consent, and only after those confirmations
create/open the file and append entries while logging the chosen persistence
mode.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d200d3f8-4693-4659-9f05-73748f95fec5

📥 Commits

Reviewing files that changed from the base of the PR and between 3865313 and bcf6023.

📒 Files selected for processing (1)
  • plugins/trogonstack-ask/skills/ask-question/SKILL.md

@yordis yordis force-pushed the add-ask-question branch from bcf6023 to 2c551e5 Compare March 18, 2026 16:25
@yordis yordis force-pushed the add-ask-question branch 2 times, most recently from 462fe29 to 1a4dbd9 Compare March 18, 2026 16:41
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@yordis yordis force-pushed the add-ask-question branch 4 times, most recently from 23329ea to a646150 Compare March 18, 2026 17:08
@yordis yordis changed the title feat: add trogonstack-ask plugin feat(ask): add trogonstack-ask plugin Mar 18, 2026
@yordis yordis force-pushed the add-ask-question branch from a646150 to b5742bb Compare March 18, 2026 17:10
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis force-pushed the add-ask-question branch from b5742bb to eb8bb44 Compare March 18, 2026 17:10
@yordis yordis changed the title feat(ask): add trogonstack-ask plugin feat(trogonstack-ask): add trogonstack-ask plugin Mar 18, 2026
@yordis yordis merged commit 3fa7f6e into main Mar 18, 2026
3 checks passed
@yordis yordis deleted the add-ask-question branch March 18, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant