feat(trogonstack-ask): add trogonstack-ask plugin#22
Conversation
PR SummaryLow Risk Overview Registers Written by Cursor Bugbot for commit eb8bb44. This will update automatically on new commits. Configure here. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughAdds a new trogonstack-ask plugin: plugin manifest, a skill doc describing a structured one-question-at-a-time "ask-question" workflow, and registers the plugin in marketplace and release-please metadata. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Important Merge conflicts detected (Beta)
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/trogonstack-ask/.claude-plugin/plugin.json`:
- Around line 2-4: Add the new plugin directory "plugins/trogonstack-ask" to the
release-please configuration by updating the packages array in the repository's
release-please config (the JSON object containing the "packages" key) to include
an entry for the plugin; ensure the entry references the package path
"plugins/trogonstack-ask" (and set any required metadata like packageName or
releaseType consistent with other entries) so automated release/versioning will
include this new plugin.
In `@plugins/trogonstack-ask/skills/ask-question/SKILL.md`:
- Line 20: Update the Q&A save flow described in SKILL.md so that before
creating any file (the step that currently reads "Before asking the first
question, ask the user if they want the Q&A session saved to a file") the skill
explicitly: 1) prompts the user for and confirms the desired filename/path
(showing a safe default), 2) validates the filename (reject absolute paths and
path traversal like ../), 3) asks and records explicit consent for persistence
and for overwrite if the file exists, 4) offers a redaction/minimization toggle
to remove or mask sensitive fields before writing, and 5) logs the user’s choice
and only create/append the file after these checks; implement these checks
around the code that creates/appends the file so consent, validation, overwrite
handling, and redaction are enforced every session.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f942f8fd-a06e-4297-9a21-4023d4847094
📒 Files selected for processing (2)
plugins/trogonstack-ask/.claude-plugin/plugin.jsonplugins/trogonstack-ask/skills/ask-question/SKILL.md
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
plugins/trogonstack-ask/skills/ask-question/SKILL.md (1)
22-22:⚠️ Potential issue | 🟠 MajorAdd explicit persistence safety checks before writing to disk.
Line 22 still allows immediate file creation/append without explicit filename/path confirmation, overwrite handling, or data-minimization/redaction choice. This is a privacy/compliance risk.
🔧 Suggested wording update
-Before asking the first question, ask the user if they want the Q&A session saved to a file. If they agree, create the file immediately and append each question and answer to it as the conversation progresses. +Before asking the first question, ask the user if they want the Q&A session saved to a file. If yes, ask for and confirm a safe filename/path, confirm whether to create or append if the file exists, and ask whether sensitive content should be minimized/redacted before writing. Only after explicit consent, create/append the file as the conversation progresses.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/trogonstack-ask/skills/ask-question/SKILL.md` at line 22, The current behavior described by "create the file immediately and append each question and answer to it as the conversation progresses" lacks safety checks; update the flow in SKILL.md to first prompt the user for explicit filename/path confirmation (show a safe default and validate it), check if the file already exists and ask whether to overwrite, append, or cancel, present an option to enable data minimization/redaction (and describe what will be redacted) and record the user's consent, and only after those confirmations create/open the file and append entries while logging the chosen persistence mode.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/trogonstack-ask/skills/ask-question/SKILL.md`:
- Around line 1-8: The marketplace metadata is missing an entry for the new
skill; add a JSON object for the trogonstack-ask plugin (id: "trogonstack-ask",
name: "ask-question") into the marketplace.json plugins array so it is
discoverable, including a brief description, version, icon or icon_url,
categories/tags and a pointer to the skill documentation (SKILL.md) and ensure
the file remains valid JSON (no trailing commas) and the entry keys match
existing plugin entries' schema.
---
Duplicate comments:
In `@plugins/trogonstack-ask/skills/ask-question/SKILL.md`:
- Line 22: The current behavior described by "create the file immediately and
append each question and answer to it as the conversation progresses" lacks
safety checks; update the flow in SKILL.md to first prompt the user for explicit
filename/path confirmation (show a safe default and validate it), check if the
file already exists and ask whether to overwrite, append, or cancel, present an
option to enable data minimization/redaction (and describe what will be
redacted) and record the user's consent, and only after those confirmations
create/open the file and append entries while logging the chosen persistence
mode.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d200d3f8-4693-4659-9f05-73748f95fec5
📒 Files selected for processing (1)
plugins/trogonstack-ask/skills/ask-question/SKILL.md
bcf6023 to
2c551e5
Compare
462fe29 to
1a4dbd9
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
23329ea to
a646150
Compare
a646150 to
b5742bb
Compare
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
b5742bb to
eb8bb44
Compare

Summary
trogonstack-askplugin withask-questionskillTest plan
/trogonstack-ask:ask-question