Skip to content

fix: use YAML list syntax for allowed-tools#47

Merged
yordis merged 1 commit into
mainfrom
yordis/fix-yaml
May 16, 2026
Merged

fix: use YAML list syntax for allowed-tools#47
yordis merged 1 commit into
mainfrom
yordis/fix-yaml

Conversation

@yordis
Copy link
Copy Markdown
Member

@yordis yordis commented May 16, 2026

Summary

  • The allowed-tools frontmatter field only accepts a space-separated string or a YAML list; comma-separated strings were neither and risked being parsed as a single tool name with commas.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 16, 2026

PR Summary

Low Risk
Low risk documentation/config-only change that standardizes allowed-tools frontmatter to valid YAML lists; primary risk is any downstream tooling that (incorrectly) depended on the old comma-separated scalar format.

Overview
Standardizes the allowed-tools YAML frontmatter across the skill authoring guide and multiple SKILL.md manifests to use proper YAML list syntax instead of a single comma-separated string.

This prevents misparsing of tool names (e.g., treating Read, Write as one tool) and makes tool allowlists unambiguous and consistent across skills.

Reviewed by Cursor Bugbot for commit 5f19128. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 16, 2026

Review Change Stack

Walkthrough

This PR standardizes the allowed-tools frontmatter field format across the entire skill manifest ecosystem. All 26 changes convert inline comma-separated values to multi-line YAML list syntax without altering tool sets or functionality, applied uniformly across the documentation guide and skill manifest files in six plugin modules.

Changes

Skill Manifest Format Standardization

Layer / File(s) Summary
Documentation format examples
docs/skill-authoring-guide.md
The skill authoring guide is updated to show two example skill manifests using the new multi-line YAML list format for allowed-tools (replacing inline comma-separated values in both the generic my-skill-name example and the analyze-test-coverage example).
Plugin skill manifest updates
plugins/trogonstack-ask/skills/ask-question/SKILL.md, plugins/trogonstack-datadog/skills/datadog-design-dashboard/SKILL.md, plugins/trogonstack-diataxis/skills/*/SKILL.md, plugins/trogonstack-eventmodeling/skills/*/SKILL.md, plugins/trogonstack-nats/skills/nats-design-subject/SKILL.md, plugins/trogonstack-otel/skills/*/SKILL.md
All 24 skill manifest files are updated to express allowed-tools as explicit YAML arrays (one tool per line) instead of comma-separated inline values, maintaining identical tool sets across all six plugin modules while standardizing metadata structure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

  • TrogonStack/agentskills#28: Introduced the OpenTelemetry skill files (otel-name-metric and otel-name-span) whose allowed-tools formatting is updated by this PR.
  • TrogonStack/agentskills#15: Introduced the Datadog skill (datadog-design-dashboard) whose allowed-tools format is standardized in this PR.
  • TrogonStack/agentskills#22: Originally added the ask-question skill, whose allowed-tools field is reformatted here.

Poem

🐰 A rabbit hops through manifests with care,
Converting lists with methodical flair,
Each comma traded for a bullet point bright,
Consistency ✨ shines in YAML's sight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the rationale for the change: comma-separated strings were invalid and risked incorrect parsing, while YAML lists are the correct format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the primary change: converting allowed-tools from comma-separated to YAML list syntax across multiple skill manifest files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/fix-yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comma-separated strings are not a valid form for the allowed-tools frontmatter field; only space-separated strings or YAML lists are accepted.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis force-pushed the yordis/fix-yaml branch from 0e32d3f to 5f19128 Compare May 16, 2026 18:51
@yordis yordis changed the title fix(skills): use YAML list syntax for allowed-tools fix: use YAML list syntax for allowed-tools May 16, 2026
@yordis yordis merged commit 67aaca2 into main May 16, 2026
5 checks passed
@yordis yordis deleted the yordis/fix-yaml branch May 16, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant