Skip to content

Conversation

yordis
Copy link
Member

@yordis yordis commented Sep 30, 2025

No description provided.

Copy link

coderabbitai bot commented Sep 30, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Standardized build-time version metadata (version, commit, date) for two CLI plugins, updating --version output to a consistent format and aligning tests to assert the new substrings. Removed an unused connect import in one plugin. No other logic or control-flow changes.

Changes

Cohort / File(s) Summary
Connect servicestruct plugin versioning
cmd/protoc-gen-connect-go-servicestruct/main.go, cmd/protoc-gen-connect-go-servicestruct/main_test.go
Add ldflags-driven version/commit/date vars; replace connect.Version print with formatted string; remove connectrpc.com/connect import; update test to assert presence of binary name, "commit:", and "built:".
Elixir gRPC plugin versioning
cmd/protoc-gen-elixir-grpc/main.go, cmd/protoc-gen-elixir-grpc/main_test.go
Introduce ldflags-driven version/commit/date; change --version output to formatted string; adjust test to check substrings for binary name, "commit:", and "built:".

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

A rabbit taps the build with glee,
Tags of time for all to see—
version, commit, built-on date,
neatly printed, no debate.
Two little plugins hop in line,
“--version” sings in format fine.
🥕 Done by dusk; release will shine.

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/add-version-ldflags

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8482c48 and 0e1364b.

📒 Files selected for processing (4)
  • cmd/protoc-gen-connect-go-servicestruct/main.go (2 hunks)
  • cmd/protoc-gen-connect-go-servicestruct/main_test.go (1 hunks)
  • cmd/protoc-gen-elixir-grpc/main.go (2 hunks)
  • cmd/protoc-gen-elixir-grpc/main_test.go (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

Add version, commit, and date variables to support build-time version injection via GoReleaser ldflags.
Add version, commit, and date variables to support build-time version injection via GoReleaser ldflags.
@yordis yordis force-pushed the feat/add-version-ldflags branch from 28997d4 to 0e1364b Compare September 30, 2025 01:52
@yordis yordis marked this pull request as ready for review September 30, 2025 04:26
@yordis yordis merged commit 43d354a into main Sep 30, 2025
2 of 3 checks passed
@yordis yordis deleted the feat/add-version-ldflags branch September 30, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant