fix: change OpencertsRegistryVerifier status from INVALID to SKIPPED

[rongquan1]

Summary by CodeRabbit

Release Notes

• Refactor
  • Updated registry verification logic to report "SKIPPED" status instead of "INVALID" when verification cannot be performed (e.g., missing or unknown registry store).
  • Aligned verification status reporting across V2 and V3 certificate formats for consistent behavior when registry data is unavailable.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR modifies the OpenCert registry verifier to emit SKIPPED status instead of INVALID when registry verification cannot be completed, updating the corresponding type definitions, implementation logic, and test expectations consistently across the codebase.

Changes

Cohort / File(s)	Summary
Test Expectations src/__tests__/core/verify.test.ts, src/__tests__/open-cert/verify.test.ts	Updated test assertions for OpencertsRegistryVerifier status from INVALID to SKIPPED in two test suites (3 test cases total).
Registry Verifier Implementation src/open-cert/verify.ts	Changed OpencertsRegistryVerifier to emit SKIPPED status instead of INVALID: updated fragment types from InvalidVerificationFragment to SkippedVerificationFragment, modified return status values in storeToData and registryVerifier.verify logic, and updated public type signatures accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• feat: implement opencert verify #125: Introduced the OpenCert registry verifier that is now being modified to change its status semantics from INVALID to SKIPPED.

Suggested labels

released

Poem

🐰 From INVALID paths we hop away,
To SKIPPED fragments bright today,
The registry verifier now sees clear—
When checks can't run, no false flags here! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description is missing entirely. The required template sections (Summary, Changes, Issues) were not provided by the author.	Add a pull request description following the repository template, including: background/context, detailed list of changes, and related issues or stories.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: updating OpencertsRegistryVerifier status from INVALID to SKIPPED across test files and implementation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/opencertsregistryverifier

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/open-cert/verify.ts (1)

65-65: ⚠️ Potential issue | 🟡 Minor

Stale comments still reference "invalid" status.

Line 65 and Line 197 both say "if all issuers are invalid => invalid" but the status is now SKIPPED. Update these comments to reflect the new semantics.

Proposed fix

Line 65:

-// if one issuer is valid => fragment status is valid otherwise if all issuers are invalid => invalid
+// if one issuer is valid => fragment status is valid otherwise if all issuers are invalid => skipped

Line 197:

-    // if one issuer is valid => fragment status is valid otherwise if all issuers are invalid => invalid
+    // if one issuer is valid => fragment status is valid otherwise if all issuers are invalid => skipped

Also applies to: 197-197

[tradetrustimda]

🎉 This PR is included in version 2.6.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀