Skip to content

feat: update @tradetrust-tt/tt-verify to version 9.7.0 and remove deprecated document-store#137

Merged
rongquan1 merged 2 commits intomainfrom
feat/update-tt-verify
Apr 15, 2026
Merged

feat: update @tradetrust-tt/tt-verify to version 9.7.0 and remove deprecated document-store#137
rongquan1 merged 2 commits intomainfrom
feat/update-tt-verify

Conversation

@manishdex25
Copy link
Copy Markdown
Contributor

@manishdex25 manishdex25 commented Apr 15, 2026

Summary

What is the background of this pull request?

Changes

  • What are the changes made in this pull request?
  • Change this and that, etc...

Issues

What are the related issues or stories?

Summary by CodeRabbit

  • Chores
    • Updated verification library dependency to the latest version (9.7.0).

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026

📝 Walkthrough

Walkthrough

This PR updates the @tradetrust-tt/tt-verify runtime dependency from version ^9.6.0 to ^9.7.0 and reorders the @types/node-forge dev dependency entry in package.json.

Changes

Cohort / File(s) Summary
Dependency Updates
package.json
Updated @tradetrust-tt/tt-verify to ^9.7.0 and reordered @types/node-forge within devDependencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

released

Suggested reviewers

  • rongquan1

Poem

🐰 A little bump, a version higher we climb,
Dependencies refreshed, all in due time!
Nine-point-seven brings us something new,
Minor reordering—the polish crew! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains only placeholder template sections with no actual information filled in; all required sections lack concrete details about background, changes, and related issues. Complete all sections: provide background context, list actual changes made, and reference related issues or stories. Current placeholders must be replaced with substantive content.
Title check ⚠️ Warning The PR title mentions updating @tradetrust-tt/tt-verify to 9.7.0, which is confirmed in package.json changes. However, the title claims removal of deprecated document-store, but the raw_summary shows only dependency updates and reordering with no evidence of document-store removal. Update the title to accurately reflect the actual changes: remove the document-store removal claim, or verify and document what was actually removed from the codebase.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/update-tt-verify

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@manishdex25 manishdex25 requested a review from rongquan1 April 15, 2026 05:53
@manishdex25 manishdex25 self-assigned this Apr 15, 2026
@manishdex25 manishdex25 marked this pull request as ready for review April 15, 2026 05:53
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Around line 123-124: The PR left `@trustvc/document-store` in package.json and
numerous references to it; remove the dependency line for
"@trustvc/document-store", then purge or refactor all usages in
src/document-store/* (issue, revoke, grant-role, revoke-role, transferOwnership)
that import factories/types from `@trustvc/document-store`—either delete these
modules if document-store support is being removed or re-implement them to use
the new APIs; update src/index.ts to stop exporting document-store functionality
and remove imports in verify.ts and fragments/index.ts that rely on
document-store attestations (ensure verify.ts still imports required fragments
from `@tradetrust-tt/tt-verify`), and update test fixtures/mocks to stop mocking
`@trustvc/document-store` or replace them with mocks for the new implementation so
the codebase and tests consistently reflect removal of document-store support.
- Line 123: The package.json dependency entry for "@tradetrust-tt/tt-verify"
currently pins ^9.7.0 which does not exist; update that dependency version to
"^9.6.2" so installs succeed. Ensure the change is made on the dependency entry
for "@tradetrust-tt/tt-verify" (used by imports like
openAttestationEthereumDocumentStoreStatus, verificationBuilder, verify,
createResolver, openAttestationVerifiers) and run a fresh install to verify no
API breakage.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7d2486f7-2426-42f5-b5a4-b43b2ea54cf9

📥 Commits

Reviewing files that changed from the base of the PR and between 9233a6d and cb0e0ae.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json

Comment thread package.json
Comment thread package.json
@rongquan1 rongquan1 changed the title chore: update @tradetrust-tt/tt-verify to version 9.7.0 and remove deprecated document-store feat: update @tradetrust-tt/tt-verify to version 9.7.0 and remove deprecated document-store Apr 15, 2026
@rongquan1 rongquan1 merged commit 4498837 into main Apr 15, 2026
21 checks passed
@rongquan1 rongquan1 deleted the feat/update-tt-verify branch April 15, 2026 06:04
nghaninn pushed a commit that referenced this pull request Apr 15, 2026
## [2.12.0](v2.11.1...v2.12.0) (2026-04-15)

### Features

* update @tradetrust-tt/tt-verify to version 9.7.0 and remove deprecated document-store ([#137](#137)) ([4498837](4498837))
@tradetrustimda
Copy link
Copy Markdown

🎉 This PR is included in version 2.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants