PMML export enhancements and 3.8-3.6 compatibility of rule induction code #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PMML datafields with categorical string type does not provide the set of legal values so systems that import the PMML could not use functionalities depending on that, e.g., dropdown box in ADS. Signed-off-by: Yusik Kim <kmyusk@gmail.com>
Ripper has a subtle behavior change (as if we used a different random seed) between python 3.6 and 3.7 so one of the tests was failing. Do a runtime version check to choose which expected value to use. This can be removed once we stop supporting 3.6. Signed-off-by: Yusik Kim <kmyusk@gmail.com>
kmyusk
changed the title
|
@vijay-arya could you please re-run the actions? I think it failed due to a reason unrelated to my changes, and I don't have the permission to run it. |
|
Done @kmyusk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details in the individual commit messages.
Edit: It was 3.8 not 3.7