Caching construction graphs in order to improve performance #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the outer requirements functionality.
TonyTroeff
added
the
enhancement
TonyTroeff
commented
Aug 2, 2023
Member
Author
TonyTroeff
left a comment
TonyTroeff
left a comment
There was a problem hiding this comment.
I had no comments after self-reviewing my PR.
…ter the improvements were implemented
…on` management components
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
With the current setup, each full construction graph was generated for each utility (and its dependencies recursively) for each test case combination. Of course, this caused relatively slow discovery phase.
However, we managed to think of a way to improve this by changing the approach a little bit so that caching can be used.
Motivation and Context
Optimizations are always something good for us (and this is an essential one). Also, these changes allow us to develop further on the "outer" functionalities that are planned (see #63)
Checklist