Issue 58 clip path without spaces do not render draggable vertices #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not render the DraggableVertices
…tween the percentages
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/thoughtdump/tryshape/AbMk3X7KX28LyhFdVFegpG3hxrqr |
atapas
requested changes
Jun 29, 2021
components/core/CreateShape.js
Outdated
| "y": percentageArray[1], | ||
| } | ||
| let values = x.trim(); | ||
| let xValue = values.substring(0, values.indexOf("%") + 1).trim(); |
Contributor
There was a problem hiding this comment.
@williamzhu17, the clip-path value can take other units than %. We should support them in our logic.
Collaborator
Author
There was a problem hiding this comment.
they should now be able to take in px values
…e when moving the draggablevertices
…nvalid breaks the app
…thout-spaces-do-not-render-DraggableVertices
atapas
approved these changes
Jul 6, 2021
Contributor
atapas
left a comment
atapas
left a comment
There was a problem hiding this comment.
Changes are looking good. Approving
atapas
deleted the
issue-58-clip-path-without-spaces-do-not-render-DraggableVertices
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.