Skip to content

accessibility issues #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2021
Merged

accessibility issues #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f8c33c
fixing accessibility issues
nirmalkc Jun 29, 2021
ad6364f
Merge remote-tracking branch 'origin/main' into accessibility-issues
nirmalkc Jul 7, 2021
26894df
adding lang attribute
nirmalkc Jul 7, 2021
87f0fdd
heaindg and color contrast issue fix
nirmalkc Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions components/core/Landing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ const Landing = ({ setOpen, user, setUser }) => {
return(
<div>
<BannerHeader fixed="top" expand="md">
<Navbar.Brand><Logo><div className="sr-only">TryShape</div></Logo></Navbar.Brand>
<Navbar.Brand><Logo><span className="sr-only">TryShape</span></Logo></Navbar.Brand>
<Navbar.Toggle>
<FiMenu color="var(--color-neutral-10" size="24px"/>
</Navbar.Toggle>
Expand Down Expand Up @@ -523,7 +523,7 @@ const Landing = ({ setOpen, user, setUser }) => {
<FileSupportCards>
<FileSupportCardItem>
<div className="card-icon">
<img src={IconSvg} />
<img src={IconSvg} alt="Icon for SVG File Type" />
</div>
<h3 className="card-title">SVG</h3>
<p className="card-desc">
Expand All @@ -533,7 +533,7 @@ const Landing = ({ setOpen, user, setUser }) => {
</FileSupportCardItem>
<FileSupportCardItem>
<div className="card-icon">
<img src={IconPngJpg} />
<img src={IconPngJpg} alt="Icon for PNG and JPG File Types"/>
</div>
<h3 className="card-title">PNG and JPEG</h3>
<p className="card-desc">
Expand All @@ -543,7 +543,7 @@ const Landing = ({ setOpen, user, setUser }) => {
</FileSupportCardItem>
<FileSupportCardItem>
<div className="card-icon">
<img src={IconCss} />
<img src={IconCss} alt="Icon for CSS Snippets"/>
</div>
<h3 className="card-title">CSS Snippet</h3>
<p className="card-desc">
Expand All @@ -557,11 +557,11 @@ const Landing = ({ setOpen, user, setUser }) => {
<SectionContact id="contact">
<Container>
<SocialLinks>
<a href="https://github.com/TryShape" target="_blank" rel="noopener noreferrer"><FiGithub /></a>
<a href="https://twitter.com/tapasadhikary" target="_blank" rel="noopener noreferrer"><FiTwitter /></a>
<a href="https://www.linkedin.com/in/tapasadhikary/" target="_blank" rel="noopener noreferrer"><FiLinkedin /></a>
<a href="https://www.youtube.com/c/TapasAdhikary/featured" rel="noopener noreferrer"><FiYoutube /></a>
<a href="mailto:tapas.adhikary@gmail.com" rel="noopener noreferrer"><FiMail /></a>
<a href="https://github.com/TryShape" target="_blank" rel="noopener noreferrer"><FiGithub /><span className="sr-only">GitHub</span></a>
<a href="https://twitter.com/tapasadhikary" target="_blank" rel="noopener noreferrer"><FiTwitter /><span className="sr-only">Twitter</span></a>
<a href="https://www.linkedin.com/in/tapasadhikary/" target="_blank" rel="noopener noreferrer"><FiLinkedin /><span className="sr-only">Linkedin</span></a>
<a href="https://www.youtube.com/c/TapasAdhikary/featured" rel="noopener noreferrer"><FiYoutube /><span className="sr-only">Youtube</span></a>
<a href="mailto:tapas.adhikary@gmail.com" rel="noopener noreferrer"><FiMail /><span className="sr-only">Email</span></a>
</SocialLinks>
<SectionContactCredits className="text-center"><small>TryShape is an opensource project developed by <a href="https://tapasadhikary.com/" target="_blank">Tapas Adhikary</a> and friends.</small></SectionContactCredits>
</Container>
Expand Down
4 changes: 2 additions & 2 deletions components/utils/ShapeList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ const ShapeActions = styled.div`
justify-content: space-between;
`;

const ShapeName = styled.h4`
const ShapeName = styled.h2`
display: flex;
justify-content: flex-start;
align-items: center;
Expand Down Expand Up @@ -163,7 +163,7 @@ const ShapeCreditsOwner = styled.div`
const ShapeCreditsDate = styled.small`
margin-top: 0.3rem;
font-size: var(--fs-sm);
color: var(--color-neutral-50);
color: var(--color-neutral-60);
line-height: 1;
`;

Expand Down
2 changes: 1 addition & 1 deletion pages/_document.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default class MyDocument extends Document {

render() {
return (
<Html>
<Html lang="en">
<Head>
{/* Step 5: Output the styles in the head */}
{this.props.styleTags}
Expand Down