Skip to content
This repository was archived by the owner on Jun 9, 2023. It is now read-only.

Submission gesture customization#3

Merged
Tunous merged 9 commits intomasterfrom
feature/gesture-customization
Aug 7, 2019
Merged

Submission gesture customization#3
Tunous merged 9 commits intomasterfrom
feature/gesture-customization

Conversation

@Tunous
Copy link
Copy Markdown
Owner

@Tunous Tunous commented Jan 7, 2019

Description

This pull request implements screen which allows for customization of swipe actions that should be available for each side of submissions.

Each side can have all or no actions selected and both sides can have the same actions selected. The only limitation is that the same action can't be selected multiple times for the same side.

Long pressing or holding drag handle and scrolling starts reorder action. Swipe left/right gesture can be used to remove selected swipe action. New actions can be added by using "Add action" button under corresponding group.

Submission preview at the top of the screen can be used to see how selected actions are configured.

Preview

2019-01-07_18-14-00

Tasks to finish

  • Handling situation when no actions are selected
  • Correct summary on settings tile of parent screen
  • Better text for preview submission
  • Improved wording for left / right group section headers?
  • More testing
  • Code cleanup

@Tunous Tunous added the feature New feature label Jan 7, 2019
@Tunous Tunous added this to the 0.7.0 milestone Jan 7, 2019
@Tunous Tunous self-assigned this Jan 7, 2019
@mvietri
Copy link
Copy Markdown

mvietri commented Jan 7, 2019

I can check it out later!

@mvietri
Copy link
Copy Markdown

mvietri commented Jan 8, 2019

So far so good. It's working fine!

Will be useful a 'reset' function to put back the default values?

I've found so far:

  • On landscape mode this layout will not load and if you're already there when the screen rotates it just go back to preferences.

@Tunous
Copy link
Copy Markdown
Owner Author

Tunous commented Jan 8, 2019

On landscape mode this layout will not load and if you're already there when the screen rotates it just go back to preferences.

Good find. I've fixed these issues on master branch since they aren't strictly related to this feature (4e6e753, f448ee8).

@Tunous Tunous force-pushed the feature/gesture-customization branch from 57df109 to 0078c6b Compare January 8, 2019 20:06
@Tunous Tunous force-pushed the feature/gesture-customization branch from 122d779 to 17b8f30 Compare August 4, 2019 12:59
@Tunous Tunous force-pushed the feature/gesture-customization branch from 17b8f30 to 5ec8896 Compare August 7, 2019 16:52
@Tunous Tunous changed the title [WIP] Submission gesture customization Submission gesture customization Aug 7, 2019
@Tunous Tunous merged commit 7d22fef into master Aug 7, 2019
@Tunous Tunous deleted the feature/gesture-customization branch August 7, 2019 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants