Skip to content

More misc compiler fixes #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 23, 2025
Merged

More misc compiler fixes #279

merged 11 commits into from
Sep 23, 2025

Conversation

@GarboMuffin
Copy link
Member

@GarboMuffin GarboMuffin commented Sep 22, 2025 •
edited
Loading

  • Fix Incorrect type optimizations in loop conditions #276 and add test case
    • Added case for CONTROL_WAIT_UNTIL that clears state before analyzing inputs
  • Fix Wait until block condition is incorrectly optimized (624189434 broken) #277 and add test case
    • revert c16be25
    • fix a bug in TypeState#after where variables that did not exist in other would result in type of undefined which seems wrong. changing that seems to fix the infinite loop
    • also makes a couple more optimizations happen, see changes in tw-procedure-return-recursion.sb3.tw-snapshot
  • Add test cases for some previous bugs
  • Use Object.create(null) instead of {} for the variables map, trying to avoid any weird issues resulting from variables with IDs like "toString"
    • No test case because I couldn't find anything concretely broken. It was still possible to end up with functions in state.variables though. Which seems like it might break something later on.

@GarboMuffin
Move analyzeStackBlock analyzeInputs call into the switch statement
41af457 
Makes later commits easier.
@GarboMuffin
Fix #277
44e2589 
Need to clear the state before analyzing the condition as the condition
may be re-evaluated after yielding.
@GarboMuffin
Use log.error instead of console.error
5d917cc
@GarboMuffin
Revert "Fix #273"
2639653 
This reverts commit c16be25.

Caused #276
@GarboMuffin
Add test case for #276
40715dc
@GarboMuffin
Fix TypeState#after setting variable types to undefined
5a90e13 
If a variable existed in `this` but not in `other`, its resulting type
would be set to undefined. Changing it to use the type from `this`
seems to fix #273.
@GarboMuffin
Add test case for 6a37fee
c372e92
@GarboMuffin
Add test case for 7cc8f58
445a129
@GarboMuffin
Add test case for d8c73c7
214b86a
@GarboMuffin
Add test case for 7ed29f5
4a8a5ad
@GarboMuffin
Use Object.create(null) instead of {}
e81319b 
Avoids any weird issues if variables have strange IDs like "toString"
@GarboMuffin
Copy link
Member Author

GarboMuffin commented Sep 23, 2025

@Tacodiva you definitely want to look at this at some point

it's easier to read commit-by-commit instead of the big diff

@GarboMuffin GarboMuffin merged commit d7a5f1c into develop Sep 23, 2025
2 checks passed
@GarboMuffin GarboMuffin deleted the fix-277 branch September 23, 2025 00:48
@GarboMuffin
Copy link
Member Author

GarboMuffin commented Sep 23, 2025

if there's a better way to do some of those things, let me know

@Tacodiva
Copy link
Member

Tacodiva commented Sep 24, 2025

This all looks great, good job :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wait until block condition is incorrectly optimized (624189434 broken) Incorrect type optimizations in loop conditions

3 participants

@GarboMuffin @Tacodiva