Skip to content

Conversation

@penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Oct 19, 2025

This means that AbstractPPL / DynamicPPL don't fall over for variables with non-standard types. For example, if you have the value of @varname(s) being "a string" then calling varname_leaves on this value would crash, which this PR fixes.

Essentially this makes it possible (or perhaps less impossible, since I recognise there are also more problems in DynamicPPL and eltype of varinfo) to have values of arbitrary types in models (which I would point out is especially useful for :=).

@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.40%. Comparing base (f3c890f) to head (71583f9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   86.34%   86.40%   +0.05%     
==========================================
  Files           9        9              
  Lines         454      456       +2     
==========================================
+ Hits          392      394       +2     
  Misses         62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

AbstractPPL.jl documentation for PR #146 is available at:
https://TuringLang.github.io/AbstractPPL.jl/previews/PR146/

@penelopeysm penelopeysm merged commit bb5fa01 into main Oct 19, 2025
11 of 12 checks passed
@penelopeysm penelopeysm deleted the py/leaves2 branch October 19, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants