fix varname_..._leaves for other types #146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that AbstractPPL / DynamicPPL don't fall over for variables with non-standard types. For example, if you have the value of
@varname(s)being"a string"then callingvarname_leaveson this value would crash, which this PR fixes.Essentially this makes it possible (or perhaps less impossible, since I recognise there are also more problems in DynamicPPL and eltype of varinfo) to have values of arbitrary types in models (which I would point out is especially useful for
:=).