Skip to content

Conversation

@devmotion
Copy link
Member

This PR moves the Turing files, apart from the additional algorithms which are outdated, to the src and test folders.

I had another look at #11 and unfortunately I'm not sure anymore if and how the PR could be updated in the best way. The problem is that the PR is based on an older version of Turing (the particle filter implementation was changed after it was created) and contains many different changes, e.g. files are split and renamed, docstrings are changed, arguments are renamed, and some implementations are modified. Therefore probably it will be a bit tricky to rebase or merge this PR, and to clearly separate the important changes.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 392025538

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 391994039: 0.0%
Covered Lines: 0
Relevant Lines: 303

💛 - Coveralls

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #14 (4e3fcf1) into master (2e11fbf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #14    +/-   ##
=======================================
  Coverage        0   0.00%            
=======================================
  Files           0       2     +2     
  Lines           0     303   +303     
=======================================
- Misses          0     303   +303     
Impacted Files Coverage Δ
src/container.jl 0.00% <ø> (ø)
src/smc.jl 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e11fbf...cfde2f3. Read the comment docs.

@yebai
Copy link
Member

yebai commented Nov 30, 2020

I had another look at #11 and unfortunately I'm not sure anymore if and how the PR could be updated in the best way. The problem is that the PR is based on an older version of Turing (the particle filter implementation was changed after it was created) and contains many different changes, e.g. files are split and renamed, docstrings are changed, arguments are renamed, and some implementations are modified. Therefore probably it will be a bit tricky to rebase or merge this PR, and to clearly separate the important changes.

I am more comfortable with a fresh start instead of merging #11. As far as I know, the primary goal of #11 is to remove the dependency on Turing.jl by replacing the produce/consume paradigm with an iterator paradigm. Since #11 is not complete, such changes can probably be done in a separate effort rather than rebasing #11, whichever takes less effort.

@devmotion devmotion merged commit 143b580 into master Nov 30, 2020
@devmotion devmotion deleted the move branch November 30, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants