-
Notifications
You must be signed in to change notification settings - Fork 12
Match new Libtask to v0.2 #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@yebai Had a look at the test in Turing for the new Libtask, seems like the breaking part is here: function (instr::Libtask.Instruction{}))
end |
|
thanks @FredericWantiez, it looks like the same issue that we met in #35 . @KDr2 can you create a PR for Turing to address the issue? |
Codecov Report
@@ Coverage Diff @@
## releases #36 +/- ##
============================================
+ Coverage 55.70% 56.13% +0.42%
============================================
Files 5 5
Lines 368 367 -1
============================================
+ Hits 205 206 +1
+ Misses 163 161 -2
Continue to review full report at Codecov.
|
|
@KDr2 It seems some tests hang on Julia 1.3. Could you take a look, please? |
|
I am on it now. Seems that on Julia 1.3, we got one time more consuming than it is on 1.7: v1.7: v1.3: |
I ran test cases of Turing, and all of them have passed. Had some awesome guys already fixed them? |
I think this commit TuringLang/Libtask.jl@0334a49 would fix it. |
Just moving the changes in #35 to match the last release.