-
Notifications
You must be signed in to change notification settings - Fork 37
Specialise univariate transforms #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # UnivariateDistributions need to be handled as a special case, because size(dist) is (), | ||
| # which makes the usual machinery think we are dealing with a 0-dim array, whereas in | ||
| # actuality we are dealing with a scalar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i mean isn't this just annoying, this is what i mean when i say bijectors is a pain to deal with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and also distributions to a lesser extent
size(dist) and Bijectors.output_size are not well-defined for things like LKJCholesky or ProductNamedTupleDistribution
that's fine because their use cases are (possibly) different, but dynamicppl has its own needs, and the correct solution is to have a clean api that generalises across all of these cases
Benchmark Report
Computer InformationBenchmark Results |
|
DynamicPPL.jl documentation for PR #1145 is available at: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1145 +/- ##
===========================================
+ Coverage 37.18% 81.47% +44.29%
===========================================
Files 40 40
Lines 3819 3839 +20
===========================================
+ Hits 1420 3128 +1708
+ Misses 2399 711 -1688 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
What a shocker, it doesn't. Maybe it's only noticeable for FastLDF, which is what I ran the benchmarks in #1142 on. We can shelve this for now and come back to it later. |
Sort of along the lines of #1142.
I suspect that this small patch might provide most of the perf benefits.