CompatHelper: bump compat for FillArrays to 1, (keep existing compat) #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpfiffer
force-pushed
the
compathelper/new_version/2023-06-20-00-28-10-425-02951265853
branch
from
d37d5e6 to
0a1b080
Compare
Pull Request Test Coverage Report for Build 5458464522
💛 - Coveralls |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2017 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 21 21
Lines 1427 1426 -1
======================================
+ Misses 1427 1426 -1 ☔ View full report in Codecov by Sentry. |
… existing compat) (#2019) Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
|
I'm quite certain that this is still not fixed upstream: JuliaArrays/FillArrays.jl#252 FillArrays > 1.0.0 breaks ReverseDiff and Tracker. |
yebai
deleted the
compathelper/new_version/2023-06-20-00-28-10-425-02951265853
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
FillArrayspackage from=1.0.0to=1.0.0, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Fix #2029