Branding for the OIDC login button

[jmallach]

In the recent discussion regarding login page branding (which is now implemented), the last item was rejected:

• Make the button text configurable as well

From a UX perspective, in my organization, users are very used to see branding for login buttons: "Log in via ECorp Auth". For many of them, "OIDC", "Keycloak" or whatever the label says is meaningless. They will hit the only button on the login screen, of course, but having "ECorp" in there might make them a bit less weary of falling into some phising trap.

I'd also argue that making the label configurable is pretty standard on webapps implementing native OIDC support.

Would you accept a PR for this?

[TwiN]

The only reason I declined it is that right now, there's only one button on the page when OIDC is set up, and as you said, the text is meaningless when there's only one button on the page.

I'm not strongly opposed to cosmetic changes like this, but I do have to be mindful of the complexity of the configuration file, and to me, this specific case is not really a deal breaker for anybody, and as I mentioned, if support for multiple OIDC providers is added in the future, this would require a breaking change (because the button text would need to be per provider as opposed to globally).