前回の入力をキャッシュする程度の機能 #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twil3akine
reviewed
Aug 29, 2025
Owner
Twil3akine
left a comment
Twil3akine
left a comment
There was a problem hiding this comment.
package-lock.jsonがcommitに入っているけど、bun使ってたらpackage-lock.jsonは必要なくないかな？？
Author
|
ごめそ |
Twil3akine
requested changes
Aug 29, 2025
Owner
Twil3akine
left a comment
Twil3akine
left a comment
There was a problem hiding this comment.
とりあえず、気になるところにコメント付けさせてもらったよ。コードレビューとかしたことないから失礼な書き方してたら申し訳ないです...
Twil3akine
requested changes
Aug 29, 2025
Author
|
直したよ！ |
Twil3akine
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
下限値と上限値の代わりに、前回の入力値を再訪問時に再現します。
内容はIssues #23 にあたります。
変更内容
検証済内容
課題
二回目以降のDiffの上限値が不明瞭になる。
→ 恐らくスライド形式の入力方法を導入することで解決可能
よろしくお願いします。