Skip to content

Conversation

@vernig
Copy link
Contributor

@vernig vernig commented Jan 25, 2021

This PR adds:

  • Simple README file
  • Add highlighting of the non GSM7 characters: this is really useful to quickly identify which characters cause the message to be change encoding
  • Add legend at the bottom of the page (mainly to explain the non GSM-7 highlighting)

Giuseppe Verni added 4 commits January 25, 2021 13:14
This property represents if a char is part
of the GSM-& charset (`true`)  or not (`false)
CSS class `non-gsm` is added to the `block`
@vernig
Copy link
Contributor Author

vernig commented Jan 25, 2021

@smendes while working on the npm package, I thought about some small improvements to the tool. The non GSM7 highlight is a feature that can be really useful for users to understand how to keep the message to the least amount of segments

@vernig vernig requested a review from smendes January 25, 2021 13:30
@vernig
Copy link
Contributor Author

vernig commented Jan 25, 2021

That's how those changes look like:

image

@vernig
Copy link
Contributor Author

vernig commented Feb 1, 2021

@smendes I added the GitHub corner to the page so people can access this repo. Let me know what you think

@vernig vernig merged commit 3e65791 into main Feb 10, 2021
@vernig vernig deleted the non-gsm-chars branch February 10, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants