Skip to content
This repository was archived by the owner on May 13, 2025. It is now read-only.

Conversation

@po5i
Copy link
Contributor

@po5i po5i commented Apr 2, 2020

Resolves #3

@po5i po5i force-pushed the code-exchange-upgrade branch from 24b8775 to 74e02d8 Compare April 2, 2020 22:14
@po5i po5i force-pushed the code-exchange-upgrade branch from 74e02d8 to 3abd1b2 Compare April 2, 2020 22:20
README.md Outdated
set FLASK_ENV=development
```
flask init-db
flask run

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im getting twilio.base.exceptions.TwilioRestException when running the app and registering a new user

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get any. Did you get any specific message? Was the VERIFICATION_SID env variable correct? (I also included in the documentation now).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@po5i turns out I had to manually source .env the env file. isn't that supposed to happen automatically? could we use a Makefile to contain that call along with the call that starts the service?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll check out this. It's supposed for the env vars to be loaded automatically because we're using dotenv here. But maybe the location for this line is not appropriate. I'll test a clean clone.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. I did a clean clone in a clean zsh session, followed the steps and it worked as expected (user registration and phone verification successful).

@po5i po5i changed the base branch from master to next May 11, 2020 15:14
@po5i po5i merged commit 69a51d0 into next May 13, 2020
@po5i po5i deleted the code-exchange-upgrade branch May 13, 2020 13:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code Exchange quality checklist

3 participants