Skip to content
This repository was archived by the owner on Aug 12, 2021. It is now read-only.

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 20, 2020

Bumps bcrypt from 3.0.8 to 5.0.0.

Release notes

Sourced from bcrypt's releases.

v5.0.0

  • Fix the bcrypt "wrap-around" bug. It affects passwords with lengths >= 255. It is uncommon but it's a bug nevertheless. Previous attempts to fix the bug was unsuccessful.
  • Experimental support for z/OS
  • Fix a bug related to NUL in password input
  • Update node-pre-gyp to 0.15.0

v4.0.1

bcrypt 4.0.1

v4.0.0

NAPI support

Changelog

Sourced from bcrypt's changelog.

5.0.0 (2020-06-02)

  • Fix the bcrypt "wrap-around" bug. It affects passwords with lengths >= 255. It is uncommon but it's a bug nevertheless. Previous attempts to fix the bug was unsuccessful.
  • Experimental support for z/OS
  • Fix a bug related to NUL in password input
  • Update node-pre-gyp to 0.15.0

4.0.1 (2020-02-27)

  • Fix compilation errors in Alpine linux

4.0.0 (2020-02-17)

  • Switch to NAPI bcrypt
  • Drop support for NodeJS 8
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 20, 2020
@vercel
Copy link

vercel bot commented Aug 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tywmick/nextjs-local-authentication/ohzvteezi
✅ Preview: https://nextjs-local-authentication-git-dependabot-npmandyarnbcrypt-500.tywmick.vercel.app

@TyMick
Copy link
Owner

TyMick commented Aug 20, 2020

This PR breaks the site (logging in with the demo ty/password account and then going to /settings redirects back to the login page), and it looks like this bcrypt vulnerability would only affect passwords greater than 255 bytes. I doubt anyone trying this demo would make a password that long, and besides, it's just a tech demo, not attached to anything that needs to be secure. So I don't have time to fix this at the moment, but I will add a note to the top of the readme in the rare case that someone uses this boilerplate to bootstrap their own app.

@TyMick
Copy link
Owner

TyMick commented Oct 8, 2020

Oh! Now that I see that #5 breaks the Vercel preview in the same way, I'm guessing the preview just doesn't have access to the same Vercel secrets as the main domain. I'm going to try merging this (and #5) and see what happens.

@TyMick TyMick merged commit a0c6ff0 into master Oct 8, 2020
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/bcrypt-5.0.0 branch October 8, 2020 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants