Multiblock drag to column drop only moves the first block #2533
Closed
Noyce-Joel
started this conversation in
Ideas & Enhancements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I find that when selecting multiple blocks and dragging them into an adjacent column, only the first of the selected blocks is placed into the column and the remaining blocks are seemingly left behind.
So if I have blockA, blockB and blockC and I select blockA and blockB together; then drag that selection to the left or right edge of blockC and release, what happens is blockA is appears in the new column but blockB is left where is is. I'd expect all selected blocks to appear in the new column.
Looking at
MultiColumnDropCursorPlugin.tsthehandleDropextracts only the first node from the drag slice:I'm wondering if this is a deliberate design choice to keep things simple because the multiblock column drops introduce edge cases to be avoided for now, or is this an oversight that should be fixed? I ran into this while working with multiblock selections and I'm curious is there's a reason behind the slice being narrowed to the first child.
Should this single child(0) call be replaced with a loop over all
slice.contentchildren to build adraggedBlocksarray.Beta Was this translation helpful? Give feedback.
All reactions