Skip to content

fix: remove dependency array from comments re-rendering #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
+10 −13
Merged

fix: remove dependency array from comments re-rendering #2177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
746b15a
fix: rm dependency array on comments
nperez0111 Nov 17, 2025
0e79d04
chore: use a key to unmount it
nperez0111 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions packages/react/src/components/Comments/Comment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,20 +51,17 @@ export const Comment = ({

const dict = useDictionary();

const commentEditor = useCreateBlockNote(
{
initialContent: comment.body,
trailingBlock: false,
dictionary: {
...dict,
placeholders: {
emptyDocument: dict.placeholders.edit_comment,
},
const commentEditor = useCreateBlockNote({
initialContent: comment.body,
trailingBlock: false,
dictionary: {
...dict,
placeholders: {
emptyDocument: dict.placeholders.edit_comment,
},
schema: editor.comments.commentEditorSchema || defaultCommentEditorSchema,
},
[comment.body],
);
schema: editor.comments.commentEditorSchema || defaultCommentEditorSchema,
});

const Components = useComponentsContext()!;

Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/Comments/Comments.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const Comments = ({
// Maps all comments to elements.
const comments = thread.comments.map((comment, index) => (
<Comment
key={comment.id}
key={comment.id + JSON.stringify(comment.body || "{}")}
thread={thread}
comment={comment}
showResolveButton={index === 0}
Expand Down
Loading