fix: disallow access to the domElement or isFocused if the editor is unmounted
#2187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a race condition where the editor is
unmounted before the suggestion menu has time to react to this change.This fixes the issue by making sure that the element that it is trying to access is just
undefinedif accessed when unmounted.Rationale
Changes
Impact
Testing
Screenshots/Video
Checklist
Additional Notes
Fixes #2138