Skip to content

add frame logging #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2023
Merged

add frame logging #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/editor/src/app/documentRenderers/richtext/FrameHost.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,16 @@ export function FrameHost(props: { url: string; sessionStore: SessionStore }) {
// Methods the parent is exposing to the child
methods: methods,
});
connection.promise.then((methods) => {
connectionMethods = methods;
});
console.info("parent window connecting to iframe");
connection.promise.then(
(methods) => {
console.info("connected to iframe succesfully");
connectionMethods = methods;
},
(e) => {
console.error("connection to iframe failed", e);
},
);
return iframe;
}, [props.url, props.sessionStore]);

Expand Down
13 changes: 10 additions & 3 deletions packages/frame/src/Frame.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,16 @@ export const Frame: React.FC<Props> = observer((props) => {
// Methods child is exposing to parent
methods,
});
connection.promise.then((parent) => {
connectionMethods.current = parent;
});
console.info("iframe connecting to parent window");
connection.promise.then(
(parent) => {
console.info("connected to parent window succesfully");
connectionMethods.current = parent;
},
(e) => {
console.error("connection to parent window failed", e);
},
);
}, [modelReceivers]);

const document = useResource(() => {
Expand Down