Generate json file for index search #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit0
reviewed
Mar 29, 2020
Collaborator
Gerrit0
left a comment
Gerrit0
left a comment
There was a problem hiding this comment.
I don't really want to include extra files, especially ones as large as search.js tends to be... I'll hold off on merging this until seeing what the theme changes look like.
Gerrit0
approved these changes
Apr 5, 2020
Collaborator
Gerrit0
left a comment
Gerrit0
left a comment
There was a problem hiding this comment.
Looks good! I'll hold off on merging to merge the theme PR as well so that we keep a working build.
This was referenced Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implementation of #1251.
Here I added additional file in JSON format and wrote warning for custom themes, which use JS format. JS file was not removed for backward compatibility. Next step: to support this changes in
typedoc-default-themespackage.