Reflect template parameter default values and use them as type arguments #1348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit0
reviewed
Aug 16, 2020
Collaborator
Gerrit0
left a comment
Gerrit0
left a comment
There was a problem hiding this comment.
I really dislike the special casing that we do for mixins... It is incredibly difficult to follow. I think what you did will work correctly.
Collaborator
|
Thanks! Hoping to get a release out tonight. |
Collaborator
|
Released in 0.19 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1341 and Fixes #1345
When reviewing please take a closer look at the changes here: https://github.com/TypeStrong/typedoc/compare/master...krisztianb:fix-react-template-parameters?expand=1#diff-6fc223c798b8302651796c1b41fa064a
There is a strange code regarding mixins there. I'm not entirely sure that my logic is correct.