Fix watching of definition files #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a discrepancy between the test runner and behavior when running webpack from the command line - if the previous bundle had the same hash as the current bundle in watch mode, webpack on the command line does not output any information (almost like nothing happened) whereas in the test runner we continued to operate as if something had been output. The first commit fixes that discrepancy.
Secondly, a change was made so that if a definition file is changed the hash for the compilation is also changed so that webpack does indeed output something to the screen. This reverts the changes to the
declarationWatch
test made in #100 and fixes #109.Lastly, since the hashes have changed (and since hashes will now be different based on what your environment is since file paths are now included in the hashed data) the test runner has been updated to replace any hash in webpack output with
[hash]
. This allows the tests to run in any environment without issue.cc @blakeembrey