Skip to content

Typescript Api const enum over magic number on compile options #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Typescript Api const enum over magic number on compile options #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ function ensureTypeScriptInstance(loaderOptions: LoaderOptions, loader: any): {
};

var compilerOptions: typescript.CompilerOptions = {
module: 1 /* CommonJS */
module: typescript.ModuleKind.CommonJS /* CommonJS */
};

// Load any available tsconfig.json file
Expand Down Expand Up @@ -273,8 +273,8 @@ function ensureTypeScriptInstance(loaderOptions: LoaderOptions, loader: any): {
var libFileName = 'lib.d.ts';

// Special handling for ES6 targets
if (compilerOptions.target == 2 /* ES6 */) {
compilerOptions.module = 0 /* None */;
if (compilerOptions.target == typescript.ScriptTarget.ES6 /* ES6 */) {
compilerOptions.module = typescript.ModuleKind.None /* None */;
libFileName = 'lib.es6.d.ts';
}

Expand Down Expand Up @@ -305,8 +305,8 @@ function ensureTypeScriptInstance(loaderOptions: LoaderOptions, loader: any): {
});

let newLine =
compilerOptions.newLine === 0 /* CarriageReturnLineFeed */ ? '\r\n' :
compilerOptions.newLine === 1 /* LineFeed */ ? '\n' :
compilerOptions.newLine === typescript.NewLineKind.CarriageReturnLineFeed /* CarriageReturnLineFeed */ ? '\r\n' :
compilerOptions.newLine === typescript.NewLineKind.LineFeed /* LineFeed */ ? '\n' :
os.EOL;

// make a (sync) resolver that follows webpack's rules
Expand Down