Skip to content

Conversation

@gfx
Copy link
Contributor

@gfx gfx commented Dec 15, 2017

Tests for #484

Thanks for quick response.

@coveralls
Copy link

coveralls commented Dec 15, 2017

Coverage Status

Coverage increased (+0.2%) to 77.644% when pulling 526199c on gfx:not_to_include_types_in_dependencies into 129153f on TypeStrong:master.

@blakeembrey
Copy link
Member

Sorry, I mustn't have communicated it well enough. I wanted the tests to ensure that any .d.ts file does not export an @types interface accidentally. This PR isn't necessary, what's really needed is something that'll go over all the dependencies and @types to find the types referenced in generated .d.ts files to ensure that any imports aren't used accidentally. Does that make more sense? For example:

import * as Foo from 'foo'

export const x: Foo.Bar = { ... }

In the above example Foo.Bar is a type, maybe coming from @types/foo, and it has been exported as part of the package. For a TypeScript user to use this file, @types/foo must be a dependency.

@gfx
Copy link
Contributor Author

gfx commented Dec 27, 2017

I see. It seems reasonable, but testing is not so easy. Considering.

@gfx gfx closed this Dec 27, 2017
@gfx gfx deleted the not_to_include_types_in_dependencies branch December 27, 2017 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants