-
-
Notifications
You must be signed in to change notification settings - Fork 40
Listing tests #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Listing tests #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/test_runner.sh
Chemaclass
approved these changes
Sep 9, 2023
JesusValeraDev
approved these changes
Sep 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff 😎
|
@Tito-Kati Question. Does this solves the issue with the parallel run? |
No 😞 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
I've developed the output format of the renderResult function to align with what was discussed in issue #26.
Now it counts tests and assertions separately. A test is considered failed when any assertion fails or when a non-zero code is returned within the test.
A test is counted as passed when all assertions inside the test pass.
Tests and assertions that have passed or failed are not displayed if there aren't any, similar to Jest's style
And many variable and function names have been refactored because @Chemaclass and I got carried away.
It's not Friday, so it can be deployed to production without any issues 😉.