Skip --init option tests for NixOS #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Those tests were not an issue on a remote ( 
Link: https://logs.ofborg.org/?key=nixos/nixpkgs.428781&attempt_id=dc72694f-7def-4eaa-8377-bfb82bb039de On my own local NixOS machine ( 
I think this PR should be reverted. I also think the issue was only present on Darwin (MacOS). Sadly, I don't have access to a Mac to test at the moment, but I'am pretty sure that skipping tests "because it is NixOS" is a bad idea. |
Member
Author
|
Ok, I will revert it for now and try to think another way to solve this, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
When
nix run github:NixOS/nixpkgs#bashunit -- -vusingbashunit 0.22.3I get an error for the --init tests due to lack of permission to create directory/files // CC @drupol🔖 Changes
--initoption tests for NixOS✅ To-do list
CHANGELOG.mdto reflect the new feature or fix