Refactor the SGD method #100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #75 |
Refactors the stochastic gradient descent method into a standalone function (inside a soon-to-be populated
solversmodule) that can be called across the code-base.This has the bonus of making the
two_normal_examplea bit nicer looking (since we don't have to manually setup the optimisation loop itself).Other additions include:
PyTreeobjects. This is so that we can take the norms of gradient vectors without worrying about the container that their arguments are passed in as (which in turn dictates the format of the returned gradients).Main motivation behind doing this is so that we can then apply SGD within the Quadratic Penalty Method, which is one of the focuses of #75.