numpy -> jax.numpy everywhere
#102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #44 |
Switches
numpytojax.numpyeverywhere in the codebase. We keepnumpy.typing.ArrayLikeas a typehint because it's still applicable tojaxarrays anyway (andjaxdoesn't have a good typehinting library of it's own).This was largely a like-for-like switch of
np->jnpeverywhere, save for intest_parameter_node.pywhere I think we had both a bug and something incompatible withjnp.allclose.allclose( node.sample(...)[0], [0.3]*10), however this only compares the first element of our generated samples to 10 values in the generated list. The reaplcement removes the0-index fetch from the samples, effectively now doingallclose( node.sample(...), [0.3]*10).jnp.allclosecan't handle when one of the containers is a list, so swapped out[0.3]*10forjnp.full((10,), 0.3)which builds an identically shaped and filled array.There's also the usual
ruffformatting that it wants to perform now that imports have changed.