Skip to content

Conversation

@mscroggs
Copy link
Collaborator

@mscroggs mscroggs commented Aug 4, 2025

Fixing errors caused by distrax: eg https://github.com/UCL/causalprog/actions/runs/16727174559/job/47345807985?pr=42

I've opened #57 to remind us to undo this when we can

@mscroggs mscroggs changed the title pin jax version Fix jax errors Aug 4, 2025
@mscroggs
Copy link
Collaborator Author

mscroggs commented Aug 4, 2025

I'm amazed that I can't find mention of this issue on the distrax issue tracker...

@mscroggs mscroggs requested a review from willGraham01 August 4, 2025 15:52
This was referenced Aug 4, 2025
@willGraham01
Copy link
Collaborator

willGraham01 commented Aug 5, 2025

distrax's commit history and activity doesn't look super promising for the life of the repo either... maybe not one to take going forward. (Though I think we agreed that we'll default to JAX where possible).

Will approve this so we can keep working without too many changes for now.

@willGraham01 willGraham01 merged commit b1f2676 into main Aug 5, 2025
5 checks passed
@willGraham01 willGraham01 deleted the mscroggs/distrax-fix branch August 5, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants