Remove distrax and unpin jax version
#73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class will be removed from the codebase anyway, so there is no point preserving the tests for it. However, we should hold off merging this branch until DistributionFamily is well and truly gone.
mscroggs
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #57 |
distraxlooks long-abandoned, so we should jump ship too. This PR removesdistraxas a requirement for the testing suite, which in turn lets us un-pin thejaxversion.As a note;
DistributionFamilyhas only a single test, that usesdistrax. In light of Remove theDistributionFamilyclass. #48, the PR simply removes this test entirely, but we should hold off hitting merge until the Remove theDistributionFamilyclass. #48 is solved.Distributionhad a single test that useddistraxas a backend. This test has been edited so that, rather than comparing two different backends, the more sensible approach of comparing theDistributionimplementation with the result we expect had we used the backend package directly.pyproject.tomlhas had thejaxversion unpinned now thatdistraxis gone.