CausalProblem rework
#84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…multiplier values as separate args
mscroggs
reviewed
Aug 18, 2025
mscroggs
approved these changes
Aug 18, 2025
Collaborator
mscroggs
left a comment
mscroggs
left a comment
There was a problem hiding this comment.
Couple of placeholder docstrings and TODOs that I wanted to check we want to leave in. Otherwise looks good
Collaborator
Author
Good spot, will fix these
Yeah I want to leave them in for now, just so I then know what to put in the sub-tasks for #85. The task list is accurate, but figured I'd lay the groundwork before opening a bunch of other tasks on a class that didn't yet exist. Let me open these now before I forget... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the
CausaProblemclass from the ground-up, now that we can create models viaGraph.model.Essentially implements the "core" concepts from #85. The
test_two_normal_examplestill works as we would expect, given that we have just moved the creation of the Lagrangian from an explicit construction, to being down via theCausalProblemclass - though we are still providing thelambdaexpressions to theCausalEstimandandConstraintclasses.