-
Notifications
You must be signed in to change notification settings - Fork 76
feat(project): Add component type #1182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RandomByte
wants to merge
11
commits into
main
Choose a base branch
from
feat/component-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b421e33
feat(project): Add component type
RandomByte cf45bf4
refactor(project): Restrict component type to specVersion >= 5
RandomByte c09779e
docs(documentation): Document component type
RandomByte 3e76071
docs(documentation): Apply suggestions from UA review
RandomByte f0fb1d1
docs(documentation): Clarify difference between UI5 CLI project type …
RandomByte db2bb54
docs(documentation): Wording
RandomByte d42d9a5
docs(documentation): Update project documentation based on feedback
RandomByte 7349a62
test(project): Remove unused test fixtures
RandomByte 1ba5eac
refactor(project): Use dedicated build definition for component type
RandomByte 73659ca
refactor(project): Use enum in component schema
RandomByte 830b975
docs(documentation): Apply suggestions from UA review
RandomByte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| import {enhancePatternWithExcludes} from "./_utils.js"; | ||
| import {enhanceBundlesWithDefaults} from "../../validation/validator.js"; | ||
|
|
||
| /** | ||
| * Get tasks and their configuration for a given component project | ||
| * | ||
| * @private | ||
| * @param {object} parameters | ||
| * @param {object} parameters.project | ||
| * @param {object} parameters.taskUtil | ||
| * @param {Function} parameters.getTask | ||
| */ | ||
| export default function({project, taskUtil, getTask}) { | ||
| const tasks = new Map(); | ||
| tasks.set("escapeNonAsciiCharacters", { | ||
| options: { | ||
| encoding: project.getPropertiesFileSourceEncoding(), | ||
| pattern: "/**/*.properties" | ||
| } | ||
| }); | ||
|
|
||
| tasks.set("replaceCopyright", { | ||
| options: { | ||
| copyright: project.getCopyright(), | ||
| pattern: "/**/*.{js,json}" | ||
| } | ||
| }); | ||
|
|
||
| tasks.set("replaceVersion", { | ||
| options: { | ||
| version: project.getVersion(), | ||
| pattern: "/**/*.{js,json}" | ||
| } | ||
| }); | ||
|
|
||
| // Support rules should not be minified to have readable code in the Support Assistant | ||
| const minificationPattern = ["/**/*.js", "!**/*.support.js"]; | ||
| const minificationExcludes = project.getMinificationExcludes(); | ||
| if (minificationExcludes.length) { | ||
| enhancePatternWithExcludes(minificationPattern, minificationExcludes, "/resources/"); | ||
| } | ||
|
|
||
| tasks.set("minify", { | ||
| options: { | ||
| pattern: minificationPattern | ||
| } | ||
| }); | ||
|
|
||
| tasks.set("enhanceManifest", {}); | ||
|
|
||
| tasks.set("generateFlexChangesBundle", {}); | ||
|
|
||
| const bundles = project.getBundles(); | ||
| const existingBundleDefinitionNames = | ||
| bundles.map(({bundleDefinition}) => bundleDefinition.name).filter(Boolean); | ||
|
|
||
| const componentPreloadPaths = project.getComponentPreloadPaths(); | ||
| const componentPreloadNamespaces = project.getComponentPreloadNamespaces(); | ||
| const componentPreloadExcludes = project.getComponentPreloadExcludes(); | ||
| if (componentPreloadPaths.length || componentPreloadNamespaces.length) { | ||
| tasks.set("generateComponentPreload", { | ||
| options: { | ||
| paths: componentPreloadPaths, | ||
| namespaces: componentPreloadNamespaces, | ||
| excludes: componentPreloadExcludes, | ||
| skipBundles: existingBundleDefinitionNames | ||
| } | ||
| }); | ||
| } else { | ||
| // Default component preload | ||
| tasks.set("generateComponentPreload", { | ||
| options: { | ||
| namespaces: [project.getNamespace()], | ||
| excludes: componentPreloadExcludes, | ||
| skipBundles: existingBundleDefinitionNames | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| if (bundles.length) { | ||
| tasks.set("generateBundle", { | ||
| requiresDependencies: true, | ||
| taskFunction: async ({workspace, dependencies, taskUtil, options}) => { | ||
| const generateBundleTask = await getTask("generateBundle"); | ||
| // Async resolve default values for bundle definitions and options | ||
| const bundlesDefaults = await enhanceBundlesWithDefaults(bundles, taskUtil.getProject()); | ||
|
|
||
| return bundlesDefaults.reduce(async function(sequence, bundle) { | ||
| return sequence.then(function() { | ||
| return generateBundleTask.task({ | ||
| workspace, | ||
| dependencies, | ||
| taskUtil, | ||
| options: { | ||
| projectName: options.projectName, | ||
| bundleDefinition: bundle.bundleDefinition, | ||
| bundleOptions: bundle.bundleOptions | ||
| } | ||
| }); | ||
| }); | ||
| }, Promise.resolve()); | ||
| } | ||
| }); | ||
| } else { | ||
| // No bundles defined. Just set task so that it can be referenced by custom tasks | ||
| tasks.set("generateBundle", { | ||
| taskFunction: null | ||
| }); | ||
| } | ||
|
|
||
| tasks.set("generateVersionInfo", { | ||
| requiresDependencies: true, | ||
| options: { | ||
| rootProject: project, | ||
| pattern: "/resources/**/.library" | ||
| } | ||
| }); | ||
|
|
||
| tasks.set("generateCachebusterInfo", { | ||
| options: { | ||
| signatureType: project.getCachebusterSignatureType(), | ||
| } | ||
| }); | ||
|
|
||
| tasks.set("generateResourcesJson", {requiresDependencies: true}); | ||
|
|
||
| return tasks; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.