ci: Fix Coveralls Bot from spamming coverage info #1205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxreichmann
force-pushed
the
ci/fix-coveralls-pr-summary
branch
3 times, most recently
from
4fa712a to
c2ad219
Compare
d3xter666
previously requested changes
Nov 21, 2025
maxreichmann
force-pushed
the
ci/fix-coveralls-pr-summary
branch
from
46e337b to
6009c2c
Compare
Member
Author
|
Rebased |
matz3
previously approved these changes
Nov 21, 2025
maxreichmann
force-pushed
the
ci/fix-coveralls-pr-summary
branch
from
6009c2c to
950f405
Compare
maxreichmann
dismissed
d3xter666’s stale review
All discussions resolved. Dismiss approved by @d3xter666
Member
Author
|
Rebased |
d3xter666
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the Coveralls Bot's been spamming the Coverage info as PR comments. It's assumed, the bot's doing it because we have a Coveralls upload step for every package.
This PR tries to fix this by using the built-in "parallel" upload job feature by Coveralls itself. For now, this seems to have fixed the problem (as seen in the PR checks themselves).
This only creates one minor drawback: There are now 6 instead of only one check in the list.
Additionally, this PR changes the tests execution step (inside
github-ci.yml) from "npm run unit" back to "npm run coverage".This is done because
coverage.ymlonly checks inside "packages/" and not "internal/".