feat: Detect deprecations in ui5.yaml (in root directory)#39
Merged
Conversation
flovogt
reviewed
Apr 9, 2024
maxreichmann
force-pushed
the
analyze-ui5.yaml
branch
2 times, most recently
from
de24d88 to
aecf1d3
Compare
d3xter666
reviewed
Apr 10, 2024
d3xter666
reviewed
Apr 10, 2024
maxreichmann
force-pushed
the
analyze-ui5.yaml
branch
from
0f264d0 to
02b4c69
Compare
flovogt
force-pushed
the
analyze-ui5.yaml
branch
3 times, most recently
from
d599ba2 to
3599d48
Compare
maxreichmann
force-pushed
the
analyze-ui5.yaml
branch
from
3599d48 to
6d42145
Compare
maxreichmann
requested review from
RandomByte
and removed request for
RandomByte,
flovogt and
matz3
flovogt
reviewed
Apr 15, 2024
matz3
reviewed
Apr 15, 2024
flovogt
previously approved these changes
Apr 16, 2024
matz3
reviewed
Apr 16, 2024
- Add js-yaml npm library for YAML-parsing (https://www.npmjs.com/package/js-yaml)
test: Add test for multi-doc ui5.yaml's test: Add test for empty ui5.yaml's
maxreichmann
force-pushed
the
analyze-ui5.yaml
branch
from
a1a4aa5 to
257b9f1
Compare
matz3
reviewed
Apr 17, 2024
flovogt
previously approved these changes
Apr 17, 2024
maxreichmann
requested review from
RandomByte
and removed request for
RandomByte
RandomByte
requested changes
Apr 17, 2024
Member
RandomByte
left a comment
RandomByte
left a comment
There was a problem hiding this comment.
Looking good, just a nitpick
flovogt
approved these changes
Apr 17, 2024
RandomByte
approved these changes
Apr 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YamlLinterNoDeprecatedApirule testJIRA: CPOUI5FOUNDATION-822