Skip to content

Conversation

@sap-ospo-bot
Copy link
Contributor

The PR is fixing and updating the Reuse compliance to match the recent Reuse API Specification - we remove the dep5 file and migrate to the toml file. For more details please read the Reuse Specification

@akudev
Copy link
Member

akudev commented Mar 26, 2025

@ajinkyapatil8190 As long as the PR does not pass the checks and even the commit message does not meet the requirements, you will not get a positive review.

@cla-assistant
Copy link

cla-assistant bot commented Sep 9, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@akudev akudev force-pushed the Reuse-Migration-TOML-Branch branch from faf3e9b to 4d1ee45 Compare October 15, 2025 15:38
@akudev akudev changed the title [chore]:Reuse API update - Migration from dep5 file to TOML file. chore: Reuse API update - Migration from dep5 file to TOML file. Oct 15, 2025
@akudev akudev requested a review from petermuessig October 15, 2025 15:39
@akudev akudev force-pushed the Reuse-Migration-TOML-Branch branch 2 times, most recently from 860222d to dd3c54b Compare October 15, 2025 15:41
@akudev akudev marked this pull request as draft October 15, 2025 16:03
@akudev
Copy link
Member

akudev commented Oct 15, 2025

This needs some more work

Also, remove the license-copying, which was basically wrong as 1.) REUSE
info is only relevant in the repository, not in the npm package, and 2.)
even if it was relevant, copying from the root to all subfolders would
have broken references and added license infos which are not even
relevant for each subpackage. If only one subpackage would have been
under a different license or have contained single files under a
different license, then all packages would have received a copy of that
license.
Instead, each published npm package gets a copy of the license.
@akudev akudev force-pushed the Reuse-Migration-TOML-Branch branch from dd3c54b to be6713b Compare October 16, 2025 08:44
@akudev
Copy link
Member

akudev commented Oct 16, 2025

Alright, this was more work than expected, but is done now. Beyond the pure migration to REUSE.toml I had to remove the old and wrong "legal stuff copying mechanism".

@akudev akudev marked this pull request as ready for review October 16, 2025 08:46
@akudev akudev merged commit ea8b0cc into main Oct 20, 2025
6 of 7 checks passed
@akudev akudev deleted the Reuse-Migration-TOML-Branch branch October 20, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants