-
Notifications
You must be signed in to change notification settings - Fork 106
Labels
Description
Describe the bug
The type of onRowClick of interface AnalyticalTablePropTypes is defined in file packages/main/src/components/AnalyticalTable/types/index.ts:
onRowClick?: (e: OnRowClickEvent) => void;Which is:
interface OnRowClickEvent extends Omit<MouseEvent, 'detail'> {
detail: { detail: { row: unknown; nativeDetail: number } };
}This is incorrect, based on the code in packages/main/src/components/AnalyticalTable/hooks/useSingleRowStateSelection.ts, it should be one level of detail, not nested two levels.
Isolated Example
No response
Reproduction steps
N/A
Expected Behaviour
Better typing definition:
interface OnRowClickEvent extends Omit<UIEvent, 'detail'> {
detail: { row: unknown; nativeDetail: number };
}Screenshots or Videos
No response
UI5 Web Components for React Version
2.3.1
UI5 Web Components Version
2.3.0
Browser
Chrome, Edge, Firefox, Safari
Operating System
No response
Additional Context
No response
Relevant log output
No response
Organization
No response
Declaration
- I’m not disclosing any internal or sensitive information.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
🆕 New