Skip to content

fix(Event-System): Polyfill old behaviour by fallback to event.target for details #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarcusNotheis merged 1 commit into from
Mar 25, 2020
Merged

fix(Event-System): Polyfill old behaviour by fallback to event.target for details #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/base/src/utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,15 @@ export const polyfillDeprecatedEventAPI = (event: any) => {
// eslint-disable-next-line max-len
"'event.getParameters' is deprecated and will be removed in the next major release. Please use 'event.detail' instead."
);
return event.detail;
return event.parameters;
};
event.getParameter = (parameter: keyof typeof event.detail) => {
deprecationNotice(
'Event',
// eslint-disable-next-line max-len
"'event.getParameter' is deprecated and will be removed in the next major release. Please use 'event.detail[parameter]' instead."
);
return event.detail[parameter];
return event.parameters[parameter];
};
event.getHtmlSourceElement = () => {
deprecationNotice(
Expand All @@ -79,7 +79,12 @@ export const polyfillDeprecatedEventAPI = (event: any) => {
// eslint-disable-next-line max-len
"'event.parameters' is deprecated and will be removed in the next major release. Please use 'event.detail' instead."
);
return event.detail[prop];
if (event.detail && event.detail.hasOwnProperty(prop)) {
return event.detail[prop];
}

// really dirty fallback to e.target
return event.target[prop];
}
}
);
Expand Down