Skip to content

Fixed Table and adapt slot handling #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2019
Merged

Fixed Table and adapt slot handling #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe647e8
fix(Table): Adapt to new Web Components API
MarcusNotheis Jul 3, 2019
0987a99
docs: Fixed Demos
MarcusNotheis Jul 3, 2019
e9d185f
chore(framework): Use prop `slot` instead of `data-ui5-slot`
MarcusNotheis Jul 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/main/__karma_snapshots__/ActionSheet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@
<ThemeProvider theme={{...}}>
<WithStyles(ActionSheet) openBy={{...}} placement="Bottom">
<ActionSheet openBy={{...}} placement="Bottom" classes={{...}} theme={{...}}>
<Popover noHeader={true} openBy={{...}} placementType="Bottom" style={[undefined]} data-ui5-slot={[undefined]} initialFocus={{...}} headerText="" horizontalAlign="Center" verticalAlign="Center">
<Popover noHeader={true} openBy={{...}} placementType="Bottom" style={[undefined]} slot={[undefined]} initialFocus={{...}} headerText="" horizontalAlign="Center" verticalAlign="Center">
<div style={{...}} onClick={[Function]}>
<Button design="Default">
<ui5-button design="Default" class="" />
</Button>
</div>
<WithWebComponent(Popover) noHeader={true} placementType="Bottom" style={[undefined]} data-ui5-slot={[undefined]} initialFocus={{...}} headerText="" horizontalAlign="Center" verticalAlign="Center">
<ui5-popover no-header={true} placement-type="Bottom" style={[undefined]} data-ui5-slot={[undefined]} initial-focus={{...}} header-text="" horizontal-align="Center" vertical-align="Center" class="">
<WithWebComponent(Popover) noHeader={true} placementType="Bottom" style={[undefined]} slot={[undefined]} initialFocus={{...}} headerText="" horizontalAlign="Center" verticalAlign="Center">
<ui5-popover no-header={true} placement-type="Bottom" style={[undefined]} slot={[undefined]} initial-focus={{...}} header-text="" horizontal-align="Center" vertical-align="Center" class="">
<ul className="ActionSheet-actionSheet---" />
</ui5-popover>
</WithWebComponent(Popover)>
Expand Down
6 changes: 3 additions & 3 deletions packages/main/__karma_snapshots__/AnalyticalCard.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<div>
<WithStyles(Component) renderWhitespace={false} wrapping={true} width={{...}}>
<Component renderWhitespace={false} wrapping={true} width={{...}} classes={{...}} theme={{...}}>
<span style={{...}} className="Component-text---" title={[undefined]} data-ui5-slot={[undefined]}>
<span style={{...}} className="Component-text---" title={[undefined]} slot={[undefined]}>
Target
</span>
</Component>
Expand All @@ -61,7 +61,7 @@
<div>
<WithStyles(Component) renderWhitespace={false} wrapping={true} width={{...}}>
<Component renderWhitespace={false} wrapping={true} width={{...}} classes={{...}} theme={{...}}>
<span style={{...}} className="Component-text---" title={[undefined]} data-ui5-slot={[undefined]}>
<span style={{...}} className="Component-text---" title={[undefined]} slot={[undefined]}>
Deviation
</span>
</Component>
Expand All @@ -80,7 +80,7 @@
<div style={{...}}>
<WithStyles(Component) renderWhitespace={false} wrapping={true} width={{...}}>
<Component renderWhitespace={false} wrapping={true} width={{...}} classes={{...}} theme={{...}}>
<span style={{...}} className="Component-text---" title={[undefined]} data-ui5-slot={[undefined]}>
<span style={{...}} className="Component-text---" title={[undefined]} slot={[undefined]}>
I&#39;m a content!
</span>
</Component>
Expand Down
26 changes: 13 additions & 13 deletions packages/main/__karma_snapshots__/Avatar.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<ThemeProvider theme={{...}}>
<WithStyles(Avatar) size="XL" shape="Circle" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem">
<Avatar size="XL" shape="Circle" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem" classes={{...}} theme={{...}}>
<span className="Avatar-avatar--- Avatar-sizeXL--- Avatar-circle---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} data-ui5-slot={[undefined]} />
<span className="Avatar-avatar--- Avatar-sizeXL--- Avatar-circle---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} slot={[undefined]} />
</Avatar>
</WithStyles(Avatar)>
</ThemeProvider>
Expand All @@ -24,7 +24,7 @@
<ThemeProvider theme={{...}}>
<WithStyles(Avatar) size="XL" shape="Square" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem">
<Avatar size="XL" shape="Square" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem" classes={{...}} theme={{...}}>
<span className="Avatar-avatar--- Avatar-sizeXL---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} data-ui5-slot={[undefined]} />
<span className="Avatar-avatar--- Avatar-sizeXL---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} slot={[undefined]} />
</Avatar>
</WithStyles(Avatar)>
</ThemeProvider>
Expand All @@ -40,7 +40,7 @@
<ThemeProvider theme={{...}}>
<WithStyles(Avatar) size="L" shape="Circle" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem">
<Avatar size="L" shape="Circle" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem" classes={{...}} theme={{...}}>
<span className="Avatar-avatar--- Avatar-sizeL--- Avatar-circle---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} data-ui5-slot={[undefined]} />
<span className="Avatar-avatar--- Avatar-sizeL--- Avatar-circle---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} slot={[undefined]} />
</Avatar>
</WithStyles(Avatar)>
</ThemeProvider>
Expand All @@ -56,7 +56,7 @@
<ThemeProvider theme={{...}}>
<WithStyles(Avatar) size="L" shape="Square" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem">
<Avatar size="L" shape="Square" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem" classes={{...}} theme={{...}}>
<span className="Avatar-avatar--- Avatar-sizeL---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} data-ui5-slot={[undefined]} />
<span className="Avatar-avatar--- Avatar-sizeL---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} slot={[undefined]} />
</Avatar>
</WithStyles(Avatar)>
</ThemeProvider>
Expand All @@ -72,7 +72,7 @@
<ThemeProvider theme={{...}}>
<WithStyles(Avatar) size="M" shape="Circle" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem">
<Avatar size="M" shape="Circle" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem" classes={{...}} theme={{...}}>
<span className="Avatar-avatar--- Avatar-sizeM--- Avatar-circle---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} data-ui5-slot={[undefined]} />
<span className="Avatar-avatar--- Avatar-sizeM--- Avatar-circle---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} slot={[undefined]} />
</Avatar>
</WithStyles(Avatar)>
</ThemeProvider>
Expand All @@ -88,7 +88,7 @@
<ThemeProvider theme={{...}}>
<WithStyles(Avatar) size="M" shape="Square" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem">
<Avatar size="M" shape="Square" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem" classes={{...}} theme={{...}}>
<span className="Avatar-avatar--- Avatar-sizeM---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} data-ui5-slot={[undefined]} />
<span className="Avatar-avatar--- Avatar-sizeM---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} slot={[undefined]} />
</Avatar>
</WithStyles(Avatar)>
</ThemeProvider>
Expand All @@ -104,7 +104,7 @@
<ThemeProvider theme={{...}}>
<WithStyles(Avatar) size="S" shape="Circle" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem">
<Avatar size="S" shape="Circle" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem" classes={{...}} theme={{...}}>
<span className="Avatar-avatar--- Avatar-sizeS--- Avatar-circle---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} data-ui5-slot={[undefined]} />
<span className="Avatar-avatar--- Avatar-sizeS--- Avatar-circle---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} slot={[undefined]} />
</Avatar>
</WithStyles(Avatar)>
</ThemeProvider>
Expand All @@ -120,7 +120,7 @@
<ThemeProvider theme={{...}}>
<WithStyles(Avatar) size="S" shape="Square" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem">
<Avatar size="S" shape="Square" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem" classes={{...}} theme={{...}}>
<span className="Avatar-avatar--- Avatar-sizeS---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} data-ui5-slot={[undefined]} />
<span className="Avatar-avatar--- Avatar-sizeS---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} slot={[undefined]} />
</Avatar>
</WithStyles(Avatar)>
</ThemeProvider>
Expand All @@ -136,7 +136,7 @@
<ThemeProvider theme={{...}}>
<WithStyles(Avatar) size="XS" shape="Circle" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem">
<Avatar size="XS" shape="Circle" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem" classes={{...}} theme={{...}}>
<span className="Avatar-avatar--- Avatar-sizeXS--- Avatar-circle---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} data-ui5-slot={[undefined]} />
<span className="Avatar-avatar--- Avatar-sizeXS--- Avatar-circle---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} slot={[undefined]} />
</Avatar>
</WithStyles(Avatar)>
</ThemeProvider>
Expand All @@ -152,7 +152,7 @@
<ThemeProvider theme={{...}}>
<WithStyles(Avatar) size="XS" shape="Square" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem">
<Avatar size="XS" shape="Square" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem" classes={{...}} theme={{...}}>
<span className="Avatar-avatar--- Avatar-sizeXS---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} data-ui5-slot={[undefined]} />
<span className="Avatar-avatar--- Avatar-sizeXS---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} slot={[undefined]} />
</Avatar>
</WithStyles(Avatar)>
</ThemeProvider>
Expand All @@ -168,7 +168,7 @@
<ThemeProvider theme={{...}}>
<WithStyles(Avatar) size="Custom" shape="Circle" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem">
<Avatar size="Custom" shape="Circle" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem" classes={{...}} theme={{...}}>
<span className="Avatar-avatar--- Avatar-circle---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} data-ui5-slot={[undefined]} />
<span className="Avatar-avatar--- Avatar-circle---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} slot={[undefined]} />
</Avatar>
</WithStyles(Avatar)>
</ThemeProvider>
Expand All @@ -184,7 +184,7 @@
<ThemeProvider theme={{...}}>
<WithStyles(Avatar) size="Custom" shape="Square" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem">
<Avatar size="Custom" shape="Square" initials={{...}} image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem" classes={{...}} theme={{...}}>
<span className="Avatar-avatar---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} data-ui5-slot={[undefined]} />
<span className="Avatar-avatar---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} slot={[undefined]} />
</Avatar>
</WithStyles(Avatar)>
</ThemeProvider>
Expand All @@ -200,7 +200,7 @@
<ThemeProvider theme={{...}}>
<WithStyles(Avatar) size="XL" initials="JD" shape="Circle" image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem">
<Avatar size="XL" initials="JD" shape="Circle" image={{...}} onClick={{...}} customDisplaySize="3rem" customFontSize="1.125rem" classes={{...}} theme={{...}}>
<span className="Avatar-avatar--- Avatar-sizeXL--- Avatar-circle---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} data-ui5-slot={[undefined]}>
<span className="Avatar-avatar--- Avatar-sizeXL--- Avatar-circle---" style={{...}} onClick={[Function]} tabIndex={0} onKeyDown={[Function]} title={[undefined]} slot={[undefined]}>
JD
</span>
</Avatar>
Expand Down
4 changes: 2 additions & 2 deletions packages/main/__karma_snapshots__/Badge.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
<ThemeProvider theme={{...}}>
<Badge icon={{...}} colorScheme="1">
<ui5-badge color-scheme="1" class="">
<Icon src="sap-icon://employee" data-ui5-slot="icon">
<ui5-icon src="sap-icon://employee" data-ui5-slot="icon" class="" />
<Icon src="sap-icon://employee" slot="icon">
<ui5-icon src="sap-icon://employee" slot="icon" class="" />
</Icon>
My Badge
</ui5-badge>
Expand Down
Loading