Skip to content

docs(SelectDialog): use onSelectionChange event instead of onItemClick #6860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025
Merged

docs(SelectDialog): use onSelectionChange event instead of onItemClick #6860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/main/src/components/SelectDialog/SelectDialog.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ const MultiSelectDialog = () => {
};
// select/unselect
const handleItemClick = (e) => {
const itemDescription = e.detail.item.dataset.description;
const itemDescription = e.detail.targetItem.dataset.description;
setSelectedItems((prev) => {
if (prev[itemDescription]) {
const { [itemDescription]: _omit, ...rest } = prev;
Expand Down Expand Up @@ -122,7 +122,7 @@ const MultiSelectDialog = () => {
open={dialogOpen}
mode={ListSelectionMode.Multiple}
numberOfSelectedItems={Object.keys(selectedItems).length}
listProps={{ onItemClick: handleItemClick }}
listProps={{ onSelectionChange: handleItemClick }}
showClearButton
rememberSelections
onClear={handleClear}
Expand Down
4 changes: 2 additions & 2 deletions packages/main/src/components/SelectDialog/SelectDialog.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export const MultiSelect: Story = {
};
// select/unselect
const handleItemClick = (e) => {
const itemDescription = e.detail.item.dataset.description;
const itemDescription = e.detail.targetItem.dataset.description;
setSelectedItems((prev) => {
if (prev[itemDescription]) {
const { [itemDescription]: _omit, ...rest } = prev;
Expand Down Expand Up @@ -129,7 +129,7 @@ export const MultiSelect: Story = {
open={dialogOpen}
selectionMode={ListSelectionMode.Multiple}
numberOfSelectedItems={Object.keys(selectedItems).length}
listProps={{ onItemClick: handleItemClick }}
listProps={{ onSelectionChange: handleItemClick }}
showClearButton
rememberSelections
onClear={handleClear}
Expand Down
Loading