Skip to content

fix(ObjectPage): always show focused elements in content #7104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2025
Merged

fix(ObjectPage): always show focused elements in content #7104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c324f4
fix(ObjectPage): always show focused elements in content
Lukas742 Mar 19, 2025
f1e4dbe
Update index.tsx
Lukas742 Mar 19, 2025
3cbc457
only apply scrollPaddingBlockEnd if footer is rendered
Lukas742 Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/main/src/components/ObjectPage/ObjectPage.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@
white-space: normal;
font-family: var(--sapFontFamily);
background-color: var(--sapBackgroundColor);

overflow-x: hidden;
overflow-y: auto;
scroll-behavior: smooth;

&[data-in-iframe='true'] {
scroll-behavior: auto;
}
Expand All @@ -31,6 +33,10 @@
}
}

.withFooter {
scroll-padding-block-end: calc(var(--_ui5wcr-BarHeight) + 0.5rem);
}

.iconTabBarMode section[data-component-name='ObjectPageSection'] > div[role='heading'] {
display: none;
}
Expand Down
6 changes: 4 additions & 2 deletions packages/main/src/components/ObjectPage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,8 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
const objectPageClasses = clsx(
classNames.objectPage,
className,
mode === ObjectPageMode.IconTabBar && classNames.iconTabBarMode
mode === ObjectPageMode.IconTabBar && classNames.iconTabBarMode,
footerArea && classNames.withFooter
);

const { onScroll: _0, selectedSubSectionId: _1, ...propsWithoutOmitted } = rest;
Expand Down Expand Up @@ -735,7 +736,8 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
);

const objectPageStyles: CSSProperties = {
...style
...style,
scrollPaddingBlockStart: `${Math.ceil(topHeaderHeight + TAB_CONTAINER_HEADER_HEIGHT + (!headerCollapsed && headerPinned ? headerContentHeight : 0))}px`
};
if (headerCollapsed === true && headerArea) {
objectPageStyles[ObjectPageCssVariables.titleFontSize] = ThemingParameters.sapObjectHeader_Title_SnappedFontSize;
Expand Down
Loading