Skip to content

[ui5-side-navigation]: inappropriate exclamation mark usage #10714

@nnaydenow

Description

@nnaydenow

Bug Description

https://github.com/SAP/ui5-webcomponents/blob/main/packages/fiori/src/SideNavigation.ts#L496

getDomRef could return undefined when it's called on element that still doesn't have shadow DOM content.

There is no clear contract that says the child components will have DOM ref.

This should be revised and refactor.

Affected Component

ui5-side-navigation

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

nightly

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.

Metadata

Metadata

Labels

Type

No type

Projects

Status

Completed

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions